Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A rabbitmq-queues grow equivalent is missing for streams #10830

Closed
michaelklishin opened this issue Mar 22, 2024 · 2 comments
Closed

A rabbitmq-queues grow equivalent is missing for streams #10830

michaelklishin opened this issue Mar 22, 2024 · 2 comments

Comments

@michaelklishin
Copy link
Member

michaelklishin commented Mar 22, 2024

Much like quorum queues, streams generally assume that the (human) operator is explicit about replica management.

Over time, rabbitmq-queues add_replica was largely replaced by rabbitmq-queues grow, which
operates on groups of queues, and is more useful during automation.

However, there is no rabbitmq-streams grow, an equivalent for streams. This is because streams were not designed for environments where replicas dynamically change often enough to warrant such a command. But we can at least consider it one more time.

@SimonUnge
Copy link
Collaborator

While we are at it, perhaps add a shrink_all dito too (We already have the code for it with rabbit_stream_queue:delete_all_replicas) ?

If not started by someone, I can add a PR this weekend or so.

@michaelklishin
Copy link
Member Author

There's been some opposition to dynamically managing stream replicas. We may revisit this at some point but right now it looks like this issue won't be considered or tackled in the foreseeable future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants