From b9233f9a2d994f60892070753726d3b9e61af952 Mon Sep 17 00:00:00 2001 From: David Ansari Date: Thu, 21 Mar 2024 16:24:57 +0100 Subject: [PATCH] Fix wrong test assumptions PR #10761 added a new CLI command to list Web MQTT connections. That new CLI command relies on feature flag delete_ra_cluster_mqtt_node being enabled. This commit ensures exactly this condition. --- deps/rabbitmq_mqtt/test/command_SUITE.erl | 19 ++----------------- 1 file changed, 2 insertions(+), 17 deletions(-) diff --git a/deps/rabbitmq_mqtt/test/command_SUITE.erl b/deps/rabbitmq_mqtt/test/command_SUITE.erl index c71fdce42d08..04badd9ff526 100644 --- a/deps/rabbitmq_mqtt/test/command_SUITE.erl +++ b/deps/rabbitmq_mqtt/test/command_SUITE.erl @@ -56,24 +56,9 @@ end_per_suite(Config) -> init_per_group(unit, Config) -> Config; init_per_group(Group, Config) -> + ok = rabbit_ct_broker_helpers:enable_feature_flag(Config, delete_ra_cluster_mqtt_node), Config1 = rabbit_ct_helpers:set_config(Config, {mqtt_version, Group}), - case Group of - v4 -> - AllApps = rabbit_ct_broker_helpers:rpc_all(Config1, application, loaded_applications, []), - AllAppNames = lists:map(fun (AppList) -> - lists:map(fun ({Name, _, _}) -> Name end, AppList) - end, AllApps), - case lists:all(fun (NodeApps) -> - lists:member(rabbit_web_mqtt_app, NodeApps) - end, AllAppNames) of - true -> - Config1; - false -> - {skip, "rabbit_web_mqtt_app not available on all nodes"} - end; - v5 -> - util:maybe_skip_v5(Config1) - end. + util:maybe_skip_v5(Config1). end_per_group(_, Config) -> Config.