Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add net 6.0 so that conditional packages can be defined #1479

Closed
thompson-tomo opened this issue Jan 27, 2024 · 4 comments
Closed

Add net 6.0 so that conditional packages can be defined #1479

thompson-tomo opened this issue Jan 27, 2024 · 4 comments
Assignees
@lukebakken
Labels
enhancement
Milestone
6.9.0

Comments

@thompson-tomo
Copy link
Contributor

Is your feature request related to a problem? Please describe.

I want my dependencies to be bringing in only the bare minimum dependencies needed and to achieve this framework references should be used wherever possible

Describe the solution you'd like

A dotnet 6 or net standard 2.1? TFM should be added to the project. The additional TFM will enable the System.Memory Dependency to have a condition placed on thr reference so that it is only added when needed.

Describe alternatives you've considered

Accept additional dependencies

Additional context

This is for v6 release branch
@thompson-tomo thompson-tomo changed the title Make S6syem.Memory dependency conditional Make System.Memory dependency conditional Jan 27, 2024
@lukebakken lukebakken self-assigned this Jan 27, 2024
@lukebakken lukebakken added this to the 6.9.0 milestone Jan 27, 2024
@lukebakken
Copy link
Contributor

Feel free to open a PR to implement this. Otherwise, I will close it prior to the version 6.9.0 release, since this has not been requested before and does not seem to be a concern for most users of this library.

thompson-tomo added a commit to thompson-tomo/rabbitmq-dotnet-client that referenced this issue Jan 27, 2024
@thompson-tomo
rabbitmq#1479 Rework conditional packages in v6 branch
99f9e1e 
Have added net 6 as a TFM and implement conditional packages
@thompson-tomo thompson-tomo mentioned this issue Jan 27, 2024
Merged
6 tasks
@thompson-tomo thompson-tomo changed the title Make System.Memory dependency conditional Add net 6.0 so that conditional packages can be defined Jan 27, 2024
@thompson-tomo
Copy link
Contributor Author

thompson-tomo commented Jan 27, 2024 •
edited

Thanks @lukebakken pr #1482 submitted.

thompson-tomo added a commit to thompson-tomo/rabbitmq-dotnet-client that referenced this issue Feb 13, 2024
@thompson-tomo
rabbitmq#1479 Rework conditional packages in v6 branch
073f84c 
Have added net 6 as a TFM and implement conditional packages
@lukebakken
Copy link
Contributor

Please see the issue I see with your PR - #1482 (review)

lukebakken added a commit that referenced this issue Mar 15, 2024
@thompson-tomo @lukebakken
#1479 Rework conditional packages in v6 branch including adding net 6 (…
08e1837 
…#1482)

* Have added net 6 as a TFM and implement conditional packages

Revert NetworkOrderDeserializer

Have ported some changes from V7 + Reviewed conditional compiles

* Bump Erlang and RabbitMQ versions for CI

---------

Co-authored-by: Luke Bakken <luke@bakken.io>
@lukebakken
Copy link
Contributor

Fixed by #1482

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukebakken lukebakken

Labels
enhancement
Projects
None yet
Milestone
6.9.0
Development

No branches or pull requests
2 participants
@lukebakken @thompson-tomo