Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review TaskExtensions #1425

Closed
lukebakken opened this issue Nov 19, 2023 · 1 comment
Closed

Review TaskExtensions #1425

lukebakken opened this issue Nov 19, 2023 · 1 comment
Assignees
@lukebakken
Labels
enhancement
Milestone
7.0.0

Comments

@lukebakken
Copy link
Contributor

lukebakken commented Nov 19, 2023 •
edited

Related discussions:
@lukebakken lukebakken added this to the 7.0.0 milestone Nov 19, 2023
@lukebakken lukebakken self-assigned this Nov 19, 2023
@lukebakken lukebakken mentioned this issue Nov 19, 2023
Merged
lukebakken added a commit that referenced this issue Nov 20, 2023
@lukebakken
Ensure that the underlying timer for Task.Delay is canceled.
8b01df4 
Fixes #1425
This was referenced Nov 20, 2023
Merged
Merged
lukebakken added a commit that referenced this issue Nov 22, 2023
@lukebakken
Ensure that the underlying timer for Task.Delay is canceled.
ef1c97a 
Part of the fix to #1425

* Add EnsureCompleted task extensions.
* Don't use compiler shenanigans for AsyncRpcContinuation
* Add Ignore() extension to ignore the results of a Task
@lukebakken
Copy link
Contributor Author

Everything seems to be all set as of #1468

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukebakken lukebakken

Labels
enhancement
Projects
None yet
Milestone
7.0.0
Development

No branches or pull requests
1 participant
@lukebakken