7.0 release checklist / misc items

[lukebakken]

• Update copyright headers
• Use newer C# language features
  • readonly fields instead of get;
  • TODO
• Consider immutable collections, and / or make as many object immutable via language features as possible. See @danielmarbach's comment here
• Address TODO comments in the code
• Expose public implementation of ITcpClient or come up with a better way of setting socket options. See Removed ReceiveBufferSize and SendBufferSize to improve message rates #1415 and this discussion. Note: TcpClientAdapter was made public in Make TcpClientAdapter public #1417
• Ensure documentation XML is accurate
• Remove deprecated API methods and other entities. API should be async-only.
• Replace var with explicit types when appropriate.
• Investigate "bypassing" await when IsCompletedSuccessfully is true (though, frankly, I prefer easier-to-read code 😸). These appear to be relevant:
  • await ValueTask performance dotnet/runtime#11803
  • await ValueTask performance dotnet/runtime#11803 (comment)
  • https://blog.stephencleary.com/2016/12/eliding-async-await.html
• Do not "elide" async/await when exceptions must be caught (@danielmarbach's noticed that here)
• See if exception handling code can be simplified (see @Tornhoof's comment)
• Ensure convenience methods like QueueDeclarePassive have async versions.

[lukebakken]

@stebet what do you think of this item?

Mark all sync API methods as Obsolete. Version 8 of this lib could then be async-only.

[stebet]

@stebet what do you think of this item?

Mark all sync API methods as Obsolete. Version 8 of this lib could then be async-only.

All for it!

[bangjiehan]

Does we need QueueDeclarePassiveAsync too?

[lukebakken]

@bangjiehan -

Does we need QueueDeclarePassiveAsync too?

The QueueDeclareAsync method has a passive parameter. Set it to true, and you will do a passive declaration.

QueueDeclarePassive has always been a convenience method added to the API. I'll make a note to add it to version 7.