Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MaxMessageSize actually limits frame size #1356

Closed
lukebakken opened this issue Jun 14, 2023 · 0 comments · Fixed by #1566
Closed

MaxMessageSize actually limits frame size #1356

lukebakken opened this issue Jun 14, 2023 · 0 comments · Fixed by #1566
Assignees
@lukebakken
Labels
bug
Milestone
7.0.0

Comments

@lukebakken
Copy link
Contributor

Describe the bug

PR #1220's intent is to prevent large allocations due to bad incoming data, or large messages. The fix checks that the individual frame's size does not exceed the maximum message size, but it does not take into account the case where a large message is split into multiple frames. When combined, the message body may exceed the max message size.

Related to rabbitmq/rabbitmq-java-client#1062

Reproduction steps

N/A

Expected behavior

N/A

Additional context

N/A
@lukebakken lukebakken added the bug label Jun 14, 2023
@lukebakken lukebakken added this to the 6.6.0 milestone Jun 14, 2023
@lukebakken lukebakken self-assigned this Jun 14, 2023
@lukebakken lukebakken modified the milestones: 6.6.0, 7.0.0 Sep 21, 2023
lukebakken added a commit that referenced this issue May 14, 2024
@lukebakken
Enforce max message size with mutiple content frames
ca136ab 
Fixes #1356
@lukebakken lukebakken mentioned this issue May 14, 2024
Merged
lukebakken added a commit that referenced this issue May 15, 2024
@lukebakken
Enforce max message size with mutiple content frames
0b34430 
Fixes #1356

* Fix `TestProperties` test so that expected / actual are correct args.

* Fix passing MaxInboundMessageBodySize via connection config
lukebakken added a commit that referenced this issue May 16, 2024
@lukebakken
Enforce max message size with mutiple content frames
6f08c29 
Fixes #1356

* Fix `TestProperties` test so that expected / actual are correct args.
* Fix passing MaxInboundMessageBodySize via connection config
* Make default RMQ max message size constant Internal
* Ensure that maximum max message size is not overriden
lukebakken added a commit that referenced this issue May 16, 2024
@lukebakken
Enforce max message size with mutiple content frames
c63959f 
Fixes #1356

* Fix `TestProperties` test so that expected / actual are correct args.
* Fix passing MaxInboundMessageBodySize via connection config
* Make default RMQ max message size constant Internal
* Ensure that maximum max message size is not overriden
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukebakken lukebakken

Labels
bug
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Enforce max message size with mutiple content frames rabbitmq/rabbitmq-dotnet-client
1 participant
@lukebakken