Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review Roslyn analyzers #1269

Open
lukebakken opened this issue Oct 17, 2022 · 4 comments
Open

Review Roslyn analyzers #1269

lukebakken opened this issue Oct 17, 2022 · 4 comments
Assignees
@lukebakken
Milestone
7.0.0

Comments

@lukebakken
Copy link
Contributor

https://devblogs.microsoft.com/dotnet/configureawait-faq/
https://docs.microsoft.com/en-us/visualstudio/code-quality/ca2007?view=vs-2019
@lukebakken lukebakken added this to the 7.0.0 milestone Oct 17, 2022
@lukebakken lukebakken mentioned this issue Nov 20, 2023
Merged
@lukebakken
Copy link
Contributor Author

Example of what an analyzer might catch: #1347 (comment)

@lukebakken lukebakken self-assigned this Nov 20, 2023
lukebakken added a commit that referenced this issue Dec 18, 2023
@lukebakken
Use Microsoft.CodeAnalysis.PublicApiAnalyzers
d6d28d7 
Reference: #1269

Use the same API analysis tool that is used in the RabbitMQ.Stream.Client library.
@lukebakken lukebakken mentioned this issue Dec 18, 2023
Merged
lukebakken added a commit that referenced this issue Dec 19, 2023
@lukebakken
Use Microsoft.CodeAnalysis.PublicApiAnalyzers
1fa2325 
Reference: #1269

* Use the same API analysis tool that is used in the RabbitMQ.Stream.Client library.
* Remove existing APIApproval tests. Replaced by PublicApiAnalyzers.
* Add retries when connection can't be open due to a `SocketException`.
* Change Windows GitHub actions runner to windows-2019. It should be faster and may not have that socket exception
* Add connection retries for SocketException to SSL tests. Uncovered with windows 2019.
@lukebakken
Copy link
Contributor Author

These should eventually be enabled:

dotnet_diagnostic.RS0026.severity = none
dotnet_diagnostic.RS0027.severity = none
dotnet_diagnostic.RS0036.severity = none
dotnet_diagnostic.RS0041.severity = none

lukebakken added a commit that referenced this issue Dec 19, 2023
@lukebakken
Use Microsoft.CodeAnalysis.PublicApiAnalyzers
a0511ad 
Reference: #1269

* Use the same API analysis tool that is used in the RabbitMQ.Stream.Client library.
* Remove existing APIApproval tests. Replaced by PublicApiAnalyzers.
* Add retries when connection can't be open due to a `SocketException`.
* Change Windows GitHub actions runner to windows-2019. It should be faster and may not have that socket exception
* Add connection retries for SocketException to SSL tests. Uncovered with windows 2019.
@lukebakken
Copy link
Contributor Author

Related old issue - #444

@lukebakken lukebakken mentioned this issue Dec 21, 2023
Closed
@lukebakken
Copy link
Contributor Author

https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca2007

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukebakken lukebakken

Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

No branches or pull requests
1 participant
@lukebakken