Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to build external plugins #260

Open
noxdafox opened this issue Jan 14, 2024 · 3 comments
Open

Unable to build external plugins #260

noxdafox opened this issue Jan 14, 2024 · 3 comments
Assignees
Labels

Comments

@noxdafox
Copy link

Describe the bug

While testing a PR on my plugin: noxdafox/rabbitmq-message-deduplication#105

I could not manage to build it anymore. I could not track the core issue but I noticed this plugins suffers from the same issue.

Once running make, the following error shows up.

 DEP    ranch (2.1.0)
 DEP    rabbitmq_prelaunch ()
Error: Unknown or invalid dependency: rabbitmq_prelaunch.
make[1]: *** [../../erlang.mk:4396: /tmp/rabbitmq-delayed-message-exchange/deps/rabbitmq_prelaunch] Error 78
make[1]: Leaving directory '/tmp/rabbitmq-delayed-message-exchange/.erlang.mk/rabbitmq-server/deps/rabbit'
make: *** [erlang.mk:4512: deps] Error 2

Adding the explicit dependency (dep_rabbitmq_prelaunch) in the Makefile does not solve the issue.

Reproduction steps

Run make within the project.

Expected behavior

Dependencies are fetched and build correctly.

Additional context

No response

@noxdafox noxdafox added the bug label Jan 14, 2024
@lukebakken
Copy link
Contributor

@noxdafox - give this a try:

gotthardp/rabbitmq-email#61 (comment)

@lukebakken lukebakken self-assigned this Jan 16, 2024
@noxdafox
Copy link
Author

That does the trick but it's quite cumbersome and complicates the build and testing of external plugins quite a lot.

Is this the new way forward or is it a temporary solution while transitioning to RMQ 4?

@michaelklishin
Copy link
Member

One optimal long term solution would be for 3rd party plugins to adopt Bazel. We are not currently sure what will happen with Make. For external plugins, it may or may not remain an option (but there are no plans to remove Make/erlang.mk as an option for developing RabbitMQ itself).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants