Unable to configure TLS

[Whitespirit0]

Hello,

I'm trying to set up TLS with Hop 4.1.0, but I'm unable to import JdkHttpClientHttpLayer class in my code.
I guess it's because it's package-private?

2nd question: do the default timeouts defined in JdkHttpClientHttpLayer still apply if I follow instructions given in https://github.com/rabbitmq/hop#tls ?

Finally, do the login/password need to be passed twice (once in .setHeader("Authorization", authorization("guest", "guest"))) and once in .username("guest").password("guest")), as described in https://github.com/rabbitmq/hop#advanced-configuration?

[michaelklishin]

I will convert this issue to a GitHub discussion. Currently GitHub will automatically close and lock the issue even though your question will be transferred and responded to elsewhere. This is to let you know that we do not intend to ignore this but this is how the current GitHub conversion mechanism makes it seem for the users :(

[michaelklishin]

If JdkHttpClientHttpLayer is used in examples and this is by design, perhaps it should be made public. @acogoluegnes is it meant to be public?

I cannot find any tests that explicitly use setHeader that way, e.g. see this method.

[acogoluegnes]

JdkHttpClientHttpLayer should be public, this is a leftover from a previous design. I'll push a fix and cut a patch release.

[acogoluegnes]

Finally, do the login/password need to be passed twice (once in .setHeader("Authorization", authorization("guest", "guest"))) and once in .username("guest").password("guest")), as described in https://github.com/rabbitmq/hop#advanced-configuration?

Only if you provide your own Consumer<HttpRequest.Builder>. The default one set up the header, so you must do it if you override it.

[Whitespirit0]

Ok, thanks for your quick answer.

[acogoluegnes]

4.1.1 is out with the fix.

[Whitespirit0]

Great, thanks!

[Whitespirit0]

Looking at the code, it seems that the answer to my 2nd question (about timeouts) is:

• Default connect timeout is always applied (not sure about this)
• Default request timeout is applied only if I do not provide my own Consumer<HttpRequest.Builder> which is the case in https://github.com/rabbitmq/hop#tls
  Am I correct?

[acogoluegnes]

The source code for the defaults:

hop/src/main/java/com/rabbitmq/http/client/JdkHttpClientHttpLayer.java

Lines 244 to 263 in f127807

	HttpClient.Builder builder =
	HttpClient.newBuilder()
	.version(Version.HTTP_1_1)
	.followRedirects(Redirect.NORMAL)
	.connectTimeout(CONNECT_TIMEOUT);
	this.clientBuilderConsumer.accept(builder);
	HttpClient client = builder.build();
	ObjectMapper mapper = JsonUtils.createDefaultObjectMapper();
	String username = parameters.getUsername();
	String password = parameters.getPassword();
	Consumer<HttpRequest.Builder> requestBuilderConsumer;
	if (this.requestBuilderConsumer == null) {
	requestBuilderConsumer =
	requestBuilder ->
	requestBuilder
	.timeout(REQUEST_TIMEOUT)
	.setHeader("Authorization", authorization(username, password));
	} else {
	requestBuilderConsumer = this.requestBuilderConsumer;
	}

The connect timeout is indeed always set, but can be overridden.

The request timeout and authentication are not set as soon as you provide a Consumer<HttpRequest.Builder>.

So when setting up TLS with a Consumer<Builder> you do not override any defaults.

[Whitespirit0]

Got it, thanks.

[Whitespirit0]

@acogoluegnes, it seems that there was another leftover: the JdkHttpClientHttpLayer.Configuration#create method is also package-private. Unfortunately, this error was hidden on my side by the previous one.

[acogoluegnes]

This is what we call encapsulation :-) 4.1.2 is out with the fix. Sorry for the trouble.

[Whitespirit0]

Ha ha yes. No worries, thanks for your reactivity!