Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ksp] java.lang.NullPointerException when using custom NavArgument type #624

Closed
KarolCieslar opened this issue May 2, 2024 · 13 comments
Closed
Labels
bug Something isn't working

Comments

@KarolCieslar
Copy link

KarolCieslar commented May 2, 2024

When i try to add custom NavGraph Argument to my custom Graph (SettingGraph) i have error [ksp] java.lang.NullPointerException.
Everythings is ok when i use String, Int, Double etc as a argument type.

NavGraph:
image

Model:
image

Stacktrace: https://hastebin.skyra.pw/kikuleweru.php

Compose Destinations version: 2.1.0-beta02
KSP Version: 1.9.23-1.0.20

@raamcosta
Copy link
Owner

Hi 👋

Can you provide again the stack trace? Seems I cannot reproduce this 🤔

@raamcosta raamcosta added the feedback needed Extra attention is needed label May 6, 2024
@KarolCieslar
Copy link
Author

@raamcosta
There is a StackTrace: https://pastebin.com/jm9FHf1x

@raamcosta
Copy link
Owner

This doesn’t seem like the same one.
This looks not even related to this library. You mentioned a NullPointerException?

@KarolCieslar
Copy link
Author

KarolCieslar commented May 7, 2024

@raamcosta Oh.. i provided wrong stacktrace. Sorry for that. Here is correct one: https://pastebin.com/Y9TYRY7K

@KarolCieslar
Copy link
Author

@raamcosta can You look at this?

@raamcosta
Copy link
Owner

Sorry I have been busy these last days. I will be checking it this week.

@raamcosta raamcosta added bug Something isn't working and removed feedback needed Extra attention is needed labels May 15, 2024
@raamcosta
Copy link
Owner

You are absolutely right, thank you for reporting 🙏

Will be fixing this in the coming days!

@raamcosta
Copy link
Owner

Fix is up!

@KarolCieslar
Copy link
Author

@raamcosta there is a another error after update.
https://pastebin.com/tSNithPr

@raamcosta
Copy link
Owner

Interesting.. I will check this today

@raamcosta
Copy link
Owner

Is CardWithMask an: Enum or Parcelable or java Serializable or Ktx Serializable or has a custom type serializer?

@KarolCieslar
Copy link
Author

Oooppss i forgot about @parcelize ;/
My bad. Now everythings is working but i still do not understand how to retrive NavGraphs arguments from "nonstart" Destination. Here more info #633

@raamcosta
Copy link
Owner

Not just your bad. I also missed throwing a more helpful message in this case for graph nav args. will do so for next release.
Will also get back to you on that one later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

2 participants