Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New set of checkboxes for visible features #59

Open
raamana opened this issue Apr 6, 2022 · 8 comments · May be fixed by #62
Open

New set of checkboxes for visible features #59

raamana opened this issue Apr 6, 2022 · 8 comments · May be fixed by #62

Comments

@raamana
Copy link
Owner

raamana commented Apr 6, 2022

some facial features may still be visible after defacing such as eyes and ears, it would be help capture additional info

@raamana
Copy link
Owner Author

raamana commented Apr 7, 2022

hey @ericearl @Arshitha, do you think the checkboxes below would suffice? Feel free to suggest others. cc @agt24

['Pass',
 'Fail',
 'Brain removed',
 'faCial features',
 'eYes visible',
 'eaRs visible',
 'Unique mark(s)',
 'something Else',
 "i'm Tired",
 'review Later']

@raamana raamana linked a pull request Apr 7, 2022 that will close this issue
@Arshitha
Copy link

Arshitha commented Apr 7, 2022

Thanks Pradeep! Here's suggestion of check boxes with a couple of very minor modifications to your proposal

['Pass',
 'Fail',
 'Brain removed',
 'too much eYes visible',
 'too much eaRs visible',
 'too much Brow visible',
 'Unique mark(s)',
 'something Else',
 "i'm Tired",
 'review Later']

I think "too much Brow" is focused for our/DSST needs but rest are good prompts for general defacing QC. Also, I removed "facial features" since we are specifying eyes, ears and brow, which covers the more common points of under-stripping. I can help with this but I was wondering if we could document and provide a couple of examples for each category that's not pass or review later, so that users know what we mean by "too much ears" etc?

@raamana
Copy link
Owner Author

raamana commented Apr 7, 2022

Good suggestions Arsh, I'll add the Brow visible. More words in option might make the checkbox too long wasting space.

if you could supply some examples to documentation, that would be great. Do you know how to work with ReST formatted documentation and gh-pages of a python repo?

@Arshitha
Copy link

Arshitha commented Apr 7, 2022

It's been a while since I used ReST but it shouldn't be a problem to figure it out. Thanks, Pradeep. I'll try to get it done by next week!

@raamana
Copy link
Owner Author

raamana commented Apr 7, 2022

Great, thanks Arsh.

Also, depending on your interest/skill in Python, it would be straightforward to integrate freeview in VisualQC, given it works on your system now. If you are interested in contributing, i can walk you through what needs to be done (simply a loop calling fsleyes and managing its behaviour correctly). It shouldn't take more than a day or two.

@Arshitha
Copy link

Arshitha commented Apr 8, 2022

Sure, that sounds good but did you mean fsleyes or freeview? I haven't used freeview before but it shouldn't be too hard to figure it out.

@raamana
Copy link
Owner Author

raamana commented Apr 8, 2022

LOL, my bad, I meant fsleyes :)

@raamana
Copy link
Owner Author

raamana commented Apr 8, 2022

we will be imitating how the freesurfer module generated cortical visualization using freeview or tksurfer, but now using fsleyes -- rather straightforward to change command name and parameters:

def generate_surface_vis(self):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants