Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrate fsleyes to generate rendered images for defacing module #61

Open
raamana opened this issue Apr 6, 2022 · 8 comments
Open

Comments

@raamana
Copy link
Owner

raamana commented Apr 6, 2022

fsleyes render --scene 3d -rot 45 0 -30 --outfile tmp.99.result.deface.fsleyes.render_1.png tmp.99.result.deface.nii -dr 30 250 -cr 30 500 -in spline -bf 0.225 -r 100 -ns 500

thanks to Arshitha and Eric from NIH

@raamana
Copy link
Owner Author

raamana commented Aug 4, 2023

Hi @Arshitha, great meeting you in person at OHBM :). did you get a chance to work on this yet? Happy to do another zoom chat or code-review your progress so far. Let me know.

@Arshitha
Copy link

Arshitha commented Aug 7, 2023

Hi @raamana - same, it was really nice to meet you in-person! I worked on it a bit during the conference but nothing substantial yet. I've carved out some time this Friday to pick up where I left off. I'll take up on your offer for a zoom call if I get stuck.

@raamana
Copy link
Owner Author

raamana commented Aug 7, 2023

great, looking fwd to see this done :)

@Arshitha
Copy link

Arshitha commented Aug 11, 2023

@raamana Hello again! I spent some time on the codebase today and added the 3D renders function and modified the CLI. I have not tested it yet but I'm fairly certain it won't work as it stands. Can we schedule a meeting for next meet so I can show you what i've done so far and also, ask questions? I can send you an email to setup a meeting.

If you'd like to check out the changes I've made, they're here https://github.com/Arshitha/visualqc/tree/cli-and-3d-renders

@raamana
Copy link
Owner Author

raamana commented Aug 14, 2023

great to hear the progress, Arshitha! happy to meet later this week, but I'd suggest you give it a try to test, and see what errors you run into (beyond the basics of syntax and stringing the right functions together). That way, we can fix the issues. Its fine if you can't string them yet for lack of clarity or other issues, just let me know what they are.

I'm available in the evenings of Tuesday or thursday.

@raamana
Copy link
Owner Author

raamana commented Aug 14, 2023

I'd start with testing the generate_3d_renders function directly first (and skip the whole visualqc entry points and lot of other validation) before writing tests for how it can be integrated.

if you already tested generate_3d_renders function directly on different renders, let me know.

FYI: A friend also sent us another way to generate renders btw, and we can keep that as another option in the future, depending on how easy or hard fsleyes proves to be across platforms and software versions etc
https://cerebro-viewer.readthedocs.io/en/latest/auto_examples/volume_surface_rendering/plot_volumetric_mask_as_surface.html#sphx-glr-auto-examples-volume-surface-rendering-plot-volumetric-mask-as-surface-py

@Arshitha
Copy link

I've tested generate_3d_renders function separately but I'll try testing it within vqcdeface tomorrow. Tuesday evenings work for me. I'll email to schedule something, and I'll also take a look at the cerebro-viewer link. Thanks!

@raamana
Copy link
Owner Author

raamana commented Aug 21, 2023

Sounds good Arshitha :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants