Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use native pipe |> and update minimum R version to 4.1.0? #916

Open
iantaylor-NOAA opened this issue Feb 21, 2024 · 0 comments
Open

Use native pipe |> and update minimum R version to 4.1.0? #916

iantaylor-NOAA opened this issue Feb 21, 2024 · 0 comments
Labels
question style/refactor issues related to cleaning up the code that won't change the user experience

Comments

@iantaylor-NOAA
Copy link
Contributor

The r4ss package was slow to adopt any tidyverse stuff (because I was slow to learn it), but since January 2023 has depended on {dplyr} and {magrittr} and now has a variety of %>% throughout the code. The R native pipe operator |> has been around since May 2021 and I've started using it in my day-to-day coding.

There's a discussion about this here but the solution used within tidyverse packages seems more work than just sticking with %>%
https://www.tidyverse.org/blog/2023/04/base-vs-magrittr-pipe/#using-the-native-pipe-in-packages

I'm wondering if we can start using |> in r4ss which would require changing the minimum R version in the DESCRIPTION from 3.5.0 (from April 2018) to 4.1.0. Is anyone aware of r4ss users who's R version is more than 3 years old or have other objections to making the change?

@iantaylor-NOAA iantaylor-NOAA added question style/refactor issues related to cleaning up the code that won't change the user experience labels Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question style/refactor issues related to cleaning up the code that won't change the user experience
Projects
None yet
Development

No branches or pull requests

1 participant