Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Environmental Data display with SSplotData #863

Open
1 task done
MauroMardones opened this issue Sep 23, 2023 · 2 comments
Open
1 task done

[Feature]: Environmental Data display with SSplotData #863

MauroMardones opened this issue Sep 23, 2023 · 2 comments
Assignees

Comments

@MauroMardones
Copy link

Describe the feature request.

Is there a way for the SSplotData function to aggregate the environmental data like it does with the other sources of information in the model?

Describe alternatives you have considered

it is generally time series, in the bottom position of the plot it would be fine.

Statistical validity, if applicable

No response

Describe if this is needed for a management application

Considering that it is data that has an influence on population variables, visualizing it would be more convenient in a management context (with stakeholders), given that it is an extra source of information that always comes up for discussion.

Additional context

It's just an aesthetic issue perhaps, but it helps.

Code of Conduct

@MauroMardones
Copy link
Author

takk!

@iantaylor-NOAA
Copy link
Contributor

Steps to get this done, discussed by @iantaylor-NOAA and @e-gugliotti-NOAA:

  • get an example model with environmental data
  • add env data to the typetable in https://github.com/r4ss/r4ss/blob/main/R/SSplotData.R#L121
  • add to loop over data types to figure out which years of environmental data are present/absent
    • set size.cex = 1 for all observations since environmental data doesn't have uncertainty or sample size

@Rick-Methot-NOAA, can you share a model with environmental data with @e-gugliotti-NOAA and me? Also, in the SS3 user manual, should we add a note at the top of the environmental data section to suggest that people might want to enter it as an index instead? Currently there is a note about this near the bottom of that section but it's not very visible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants