Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Removal of unused elements of datlist from SS_readdat_3.30 #845

Open
1 task done
yukio-takeuchi opened this issue Jul 12, 2023 · 1 comment
Open
1 task done
Assignees

Comments

@yukio-takeuchi
Copy link
Contributor

Describe the feature request.

SS_readdat_3.30 leaves some elements of datlist, that may be required for 3.24 but not for 3.30.
For example,

datlist[["fleetnames"]]
datlist[["surveytiming"]]
datlist[["units_of_catch"]]
datlist[["areas"]]

are defined and derived from datlist[["fleetinfo"]] in SS_readdat_3.30 but they are not used in SS_writedat_3.30 to write datfile
I suspect they are used for 3.24 but they evoled into single fleetinfo table

Describe alternatives you have considered

At least four elements in datlist described above may be removed from SS_readdat_3.30.

Statistical validity, if applicable

No response

Describe if this is needed for a management application

No response

Additional context

No response

Code of Conduct

@yukio-takeuchi
Copy link
Contributor Author

I realized datlist[["fleetnames"]] are not used by SS_witedat_3.30.
howevr datlist[["fleetnames"]] are used by SS_readctl_3.30 if use_datlist is T to define ctllist[["fleetnames"]].
Also datlist[["fleetnames"]] are internally used by SS_readdat_3.30 to define other elements of datlist
This may be resoled by directly referencing datlist[["fleetinfo"]][["fleetname"]] in stead of datlist[["fleetnames"]] in SS_readctl_3.30
and by replacing datlist[["fleetnames"]] by datlist[["fleetinfo}]][["fleetname"]] or a new local object "fleetnames" which can be defined as

fleetnames <- datlist[["fleetinfo"]][["fleetname"]]

in SS_readdat_3.30.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants