Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ellipsis to tbl_sum(), type_sum(), obj_sum(), and size_sum() #250

Closed
krlmlr opened this issue Feb 19, 2021 · 8 comments · May be fixed by #334 or #492
Closed

Add ellipsis to tbl_sum(), type_sum(), obj_sum(), and size_sum() #250

krlmlr opened this issue Feb 19, 2021 · 8 comments · May be fixed by #334 or #492
Milestone
2.0.0

Comments

@krlmlr
Copy link
Member

krlmlr commented Feb 19, 2021

so that actual row number can be passed to implementations.

After pillar 1.5.0 and after tibble removes tbl_sum() generic.
@krlmlr krlmlr changed the title Add ... to tbl_sum() Add ellipsis tbl_sum() Feb 19, 2021
@krlmlr
Copy link
Member Author

krlmlr commented Mar 5, 2021

This is likely to need a big release because it looks like all packages implementing tbl_sum() must be adapted.

@krlmlr krlmlr added this to the 1.7.0 milestone Apr 13, 2021
@krlmlr
Copy link
Member Author

krlmlr commented Apr 13, 2021

Requires r-lib/rlang#1153.

@krlmlr krlmlr changed the title Add ellipsis tbl_sum() Add ellipsis to tbl_sum(), type_sum() and obj_sum() Apr 13, 2021
@krlmlr
Copy link
Member Author

krlmlr commented Apr 13, 2021 •
edited

Do it in a branch after 1.6.0 release, revdep pillar + tibble + anything that reexports these generics, notify downstream maintainers.

@krlmlr
Copy link
Member Author

krlmlr commented Apr 13, 2021

Reexports:

@krlmlr krlmlr changed the title Add ellipsis to tbl_sum(), type_sum() and obj_sum() Add ellipsis to tbl_sum(), type_sum(), obj_sum(), and size_sum() Apr 13, 2021
@krlmlr
Copy link
Member Author

krlmlr commented Apr 13, 2021

revdepcheck runs:

It seems sufficient to merely add ... to trigger a warning in the revdepcheck.

This was referenced Jul 22, 2021
Open
Merged
Closed
krlmlr added a commit to krlmlr/finetune that referenced this issue Oct 25, 2021
@krlmlr
Add ellipsis
60038b9 
for r-lib/pillar#250.
@krlmlr
Copy link
Member Author

krlmlr commented Oct 25, 2021

Reexported from tibble and dplyr.

@krlmlr krlmlr mentioned this issue Oct 25, 2021
Merged
krlmlr added a commit to tidyverse/tibble that referenced this issue Oct 25, 2021
@krlmlr
Add ellipsis
ec708fa 
For r-lib/pillar#250.
@krlmlr krlmlr mentioned this issue Oct 25, 2021
Merged
@krlmlr krlmlr modified the milestones: 1.7.0, 2.0.0 Jan 26, 2022
@krlmlr krlmlr mentioned this issue Jan 30, 2022
Open
topepo added a commit to tidymodels/finetune that referenced this issue Feb 21, 2022
@krlmlr @topepo
Correctly register pillar methods (#28)
8938e2b 
* Import pillar methods

* Add ellipsis

for r-lib/pillar#250.

Co-authored-by: Max Kuhn <mxkuhn@gmail.com>
@krlmlr
Copy link
Member Author

krlmlr commented Jun 30, 2022

This is too much effort for limited gain. Let's keep in mind always adding an ellipsis for new generics.

@krlmlr krlmlr closed this as not planned Won't fix, can't repro, duplicate, stale Jun 30, 2022
@github-actions
Copy link
Contributor

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

WIP: Add ellipsis to methods r-lib/pillar
WIP: Hard-deprecate, add ellipsis r-lib/pillar
1 participant
@krlmlr