Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functions that lack test in QuTiP. #18

Open
2 tasks
AGaliciaMartinez opened this issue Jul 25, 2021 · 2 comments
Open
2 tasks

Functions that lack test in QuTiP. #18

AGaliciaMartinez opened this issue Jul 25, 2021 · 2 comments

Comments

@AGaliciaMartinez
Copy link
Member

AGaliciaMartinez commented Jul 25, 2021

These are some modules in QuTiP for which there are no tests written yet. I will try to write them since they are very useful to define what an operation should do. This facilitates the development of new data types.

  • Eigen
  • ptrace
@jakelishman
Copy link
Member

I don't know all of them, but off the top of my head, the eigensolvers, ptrace and expect definitely have tests.

@AGaliciaMartinez
Copy link
Member Author

Hey Jake, thanks for pointing out that those test exist as at first I did not look beyond the tests in tests/core/data/! Indeed there is a test_expect.py (and similar for eigensolver and ptrace) in QuTiP but these seem to be testing Qobj level functionality. I was looking for tests similar to those in test_mathematics that I can inherit from and easily employ to test my own specialisations. I think that extending test_mathematics.py to provide tests for the above specialisations would be very useful. This allows QuTiP to define what the specialisations should do in a very concrete way and it helps future developers to develop new data layers.

From the discussion at yesterdays GSoC meeting, it seems that @hodgestar, @Ericgig and @quantshah agree although they suggested to extend test_mathematics in a different file for organization purposes as test_mathematics is already quite big.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants