Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate @include and @exclude metadata #650

Open
ACTCD opened this issue May 1, 2024 · 0 comments
Open

Deprecate @include and @exclude metadata #650

ACTCD opened this issue May 1, 2024 · 0 comments
Labels
enhancement Feature work
Milestone
v5.0.0

Comments

@ACTCD
Copy link
Collaborator

ACTCD commented May 1, 2024

We will deprecate @include and @exclude and only support @match and @exclude-match in the future.

  • Match pattern structure is safer and stricter, not too many accidents happen.
  • It reduces code logic, and may helps improve matching efficiency.
  • Apple never implement the @include syntax in Safari's extension API.
  • Reduce confusion and difficult choices caused by different syntaxes.

We plan to add a deprecation hint in v5 and eventually remove it in v6.0.
@ACTCD ACTCD modified the milestones: v6.0.0, v5.0.0 May 1, 2024
@ACTCD ACTCD mentioned this issue May 1, 2024
Closed
@ACTCD ACTCD added the enhancement Feature work label May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Feature work
Projects
None yet
Milestone
v5.0.0
Development

No branches or pull requests
2 participants
@ACTCD and others