Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constantly have to disable and re-enable user scripts #610

Open
theesfeld opened this issue Jan 16, 2024 · 5 comments
Open

Constantly have to disable and re-enable user scripts #610

theesfeld opened this issue Jan 16, 2024 · 5 comments
Labels
need reproduce need reproduce or more information

Comments

@theesfeld
Copy link

almost every time I load safari, my scripts don't run. I have to go to settings - extensions - and uncheck and recheck the user scripts extension, then reload the page and everything works.

@ACTCD
Copy link
Collaborator

ACTCD commented Jan 17, 2024

Not surprising this happens in Safari...(Too many peculiar "idiosyncrasies"

I'm sorry, but I really don't know what's going on, so I can't help.

The one suggestion would be to refer to #409 see if there are any logs when the problem occurs, even if it's not an error message.

@ACTCD
Copy link
Collaborator

ACTCD commented Jan 29, 2024

If you are unable to add more valid information, we will close the issue in a few days as it cannot be reproduced and investigated.

@acoffman
Copy link

acoffman commented Feb 1, 2024

I am running into the exact same issue; disabling and re-enabling the extension seems to fix it.

One potential clue I noticed is that, when this is happening, the toolbar count and the extension popover will disagree. So for example, clicking the toolbar icon will show that a script has matched:

Screenshot 2024-02-01 at 4 05 28 PM

but the toolbar icon itself will not show any matches:

Screenshot 2024-02-01 at 4 06 53 PM

Adding alerts to my Userscripts confirms that they're just not getting run at all even though the extension seems to know there is a match. Upon toggling the extension on and off, the toolbar icon again shows the match count:

Screenshot 2024-02-01 at 4 08 58 PM

And the script runs as normal.

Will try to see if there's anything interesting in the logs next time it happens.

@ACTCD
Copy link
Collaborator

ACTCD commented Feb 2, 2024

Could you describe which extension and Safari versions you use?

When the issue occurs, try checking the background page in "Develop" menu.
Does it have an unload flag? Just like background page (unloaded).

Try installing the latest beta version to see if you can reproduce the same issue.

@acoffman
Copy link

acoffman commented Feb 2, 2024

Safari Version 17.3 (19617.2.4.11.8)
Userscripts Version 4.4.5 from the App Store.

I haven't figured out a deterministic way to make the issue occur but next time it does I'll make sure to take a look at the background page and see.

I'll go ahead and try out the beta version as well, thanks!

@ACTCD ACTCD added the need reproduce need reproduce or more information label Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need reproduce need reproduce or more information
Projects
None yet
Development

No branches or pull requests

4 participants
@acoffman @theesfeld @ACTCD and others