Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull submodule from upstream #8

Open
junghans opened this issue Apr 24, 2017 · 3 comments
Open

Pull submodule from upstream #8

junghans opened this issue Apr 24, 2017 · 3 comments

Comments

@junghans
Copy link
Member

junghans commented Apr 24, 2017

Let's update submodule url to upstream where possible:

@jbakosi
Copy link
Member

jbakosi commented Apr 25, 2017

Sure. But why did you pick that particular random123 fork?

@johnsalmon, is there a github repository for random123?

@junghans
Copy link
Member Author

@jbakosi
Copy link
Member

jbakosi commented Apr 25, 2017

https://github.com/DEShawResearch/Random123-Boost appears to be boost.random wrappers around Random123. I don't think it contains the actual Random123 library (only the wrappers), plus at this point we use the raw Random123 and not via boost.random. Even if we wanted to use Random123 via boost.random, it is also not clear to me how boost.random allows sampling from different threads for parallel random number generation, which is crucial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants