Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging non-UTF-8 reasons #411

Open
hlandau opened this issue Mar 10, 2024 · 2 comments · May be fixed by #412
Open

Logging non-UTF-8 reasons #411

hlandau opened this issue Mar 10, 2024 · 2 comments · May be fixed by #412

Comments

@hlandau
Copy link

hlandau commented Mar 10, 2024

Similarly to the ALPN string issue, we define the CONNECTION_CLOSE reason string here as text:

The problem here is that RFC 9000 only says the reason string SHOULD be UTF-8. It could be arbitrary, or binary data, even if that is a bad idea.

It should be possible to log a reason string which an implementation sees which does not appear to be valid UTF-8.

@hlandau
Copy link
Author

hlandau commented Mar 10, 2024

This is related to this implementation issue: openssl/openssl#23807

@LPardue
Copy link
Member

LPardue commented Mar 10, 2024

Agree, I just had to implement this and cast to the bytes to a lossy utf8. Let's make it possible in the spec to capture raw bytes .

@LPardue LPardue linked a pull request Mar 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants