You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the raw field includes the wire representation of the frame. This doesn't seem useful, and would mean that a qlog consumer would need to implement a frame parser. Instead, we should only log the payload.
This could be done by changing the raw field to payload.
The text was updated successfully, but these errors were encountered:
So, I don't agree with this. The reason it includes the frame/packet headers currently is because we (intentionally) lose some information present in the binary form by representing the data in qlog/JSON. Users should have a way to get to the original data for low-level debugging if needed. An argument -might- be made for splitting it into a separate headers and payload (and then also trailers?) field, but not omitting headers.
Your proposal imo also only circumvents 1 layer of parsing at a time (e.g., not logging QUIC STREAM frames still requires implementing an H3/QPACK parser, not logging QUIC Packer Headers still required QUIC frame parser, etc.).
Currently the
raw
field includes the wire representation of the frame. This doesn't seem useful, and would mean that a qlog consumer would need to implement a frame parser. Instead, we should only log the payload.This could be done by changing the
raw
field topayload
.The text was updated successfully, but these errors were encountered: