Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging for paced packet sending #297

Open
LPardue opened this issue Mar 25, 2023 · 2 comments
Open

Logging for paced packet sending #297

LPardue opened this issue Mar 25, 2023 · 2 comments

Comments

@LPardue
Copy link
Member

LPardue commented Mar 25, 2023

Today qlog has packet_sent events and datagrams_sent events, which can be used to log the event and the time it occurred.

In some scenarios, the application generating packets or even datagrams is not in direct control of the emission of those packets to the wire. For example, a QUIC library may be called to generate a batch of packets that are intended to be sent out on a future time schedule. If the pacing is offloaded to some other component, such as the kernel, then reporting events in a qlog might be practically hard.

Something we've done in quiche is to add an additional send_at_time field in the packet_sent event. This contains a timestamp that the QUIC layer decided that the packet should be sent out at. We can keep that as custom extension but I was curious if others had any opinions.

@LPardue
Copy link
Member Author

LPardue commented Mar 4, 2024

We can close this when #400 lands

@rmarx
Copy link
Contributor

rmarx commented Mar 4, 2024

Small correction: not #400 but its more general spinoff, which will be tracked in #379 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants