Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move commentary on HTTP/3 frame and QUIC packetization #363

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LPardue
Copy link
Member

@LPardue LPardue commented Dec 9, 2023

Closes #280

@@ -166,6 +166,16 @@ layer, and there isn't always a one to one mapping between HTTP and QUIC events.
The exchange of data between the HTTP and QUIC layer is logged via the
"stream_data_moved" and "datagram_data_moved" events in {{QLOG-QUIC}}.

HTTP/3 frames are transmitted on QUIC streams, which allows them to span
multiple QUIC packets. Some implementations might send a single large frame,
rather than a sequence of smaller frames, in order to amortize frame header
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to specify that this only applies to DATA frames?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see the disjoint in my previous understanding of why the text was the way it was. In theory extension frames could do something similar but nothing concrete is in scope, only DATA benefits from that usage.

Frames can span packets and there might be some value is explaining that here. Let me try to tweak the text a bit more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually think the text might be fine as-is? There's also the case where you have the H3 frame headers in Packet N and the actual payload in Packet N+1 (say you have multiple streams being packed into the same packet for some reason), so not tying this down to DATA only seems fine.

If you really want, you could change it to Additionally, some implementations might send a single large frame, rather than a sequence of smaller frames..., so it's a bit clearer that the "single large frame" is a common occurrence of this issue but not the sole reason :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Commentary on H3 frames and data_moved events
3 participants