Enforce stricter extensibility for ProtocolEventData #401
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #192.
Currently,
$ProtocolEventData
accepts just about anything, which makes it extensible but very useless for any real validation.By not explicitly assigning the
* text => any
to the type in the main doc, we keep the extensibility, but improve validation capabilities.This also properly adds the Generic and Simulation events to the
$ProtocolEventData
, which they really should have been from the start ;)