The BooleanBuilder created with a NoArg constructor generates a different query from a BooleanBuilder created with an initial Arg constructor.

[jaybon1]

Observed vs. expected behavior

The BooleanBuilder created with a NoArg constructor generates a different query from a BooleanBuilder created with an initial Arg constructor.

This issue does not always occur and has occurred occasionally when building the project multiple.

Steps to reproduce

The BooleanBuilder created with the initial argument constructor produces the expected query, where all conditions (predicate, createDateAfter, and createDateBefore) are applied:

BooleanBuilder booleanBuilder = new BooleanBuilder(predicate);
booleanBuilder.and(QTempEntity.tempEntity.createDate.after(createDateAfter));
booleanBuilder.and(QTempEntity.tempEntity.createDate.before(createDateBefore));

This would result in a query like:

te1_0.delete_date is null and te1_0.create_date>? and te1_0.create_date<?

On the other hand, the BooleanBuilder created with the no-argument constructor only applies the predicate, and the additional conditions are not correctly applied:

BooleanBuilder booleanBuilder = new BooleanBuilder();
booleanBuilder.and(predicate);
booleanBuilder.and(QTempEntity.tempEntity.createDate.after(createDateAfter));
booleanBuilder.and(QTempEntity.tempEntity.createDate.before(createDateBefore));

This would result in a query like:

te1_0.delete_date is null

The query generated in this case might not be as expected.

Environment

Querydsl version: 5.0.0

Querydsl module:
com.querydsl.core.BooleanBuilder
com.querydsl.core.types.Predicate

Database: H2

JDK: 17

Additional details

Upon reviewing the BooleanBuilder code, it appears that there might be a difference in how the 'predicate' is initialized between the constructor and the 'and' method.

In the constructor:

predicate = (Predicate) ExpressionUtils.extract(initial);

However, in the 'and' method:

if (predicate == null) {
    predicate = right;
}

Is there a difference between using ExpressionUtils.extract() function and not using it?