Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: add OTLP configuration types #1870

Merged
merged 1 commit into from Oct 27, 2023
Merged

config: add OTLP configuration types #1870

merged 1 commit into from Oct 27, 2023

Conversation

hdonnay
Copy link
Member

@hdonnay hdonnay commented Sep 20, 2023

Closes #1857.

@hdonnay hdonnay added the config/minor-version Merging this requires the next release to be a minor version increment. label Sep 20, 2023
@hdonnay hdonnay force-pushed the hack/config/jaeger-proto branch 2 times, most recently from ae4ab7f to f7a70d8 Compare September 20, 2023 23:23
@hdonnay hdonnay marked this pull request as ready for review September 20, 2023 23:28
@hdonnay hdonnay requested a review from a team as a code owner September 20, 2023 23:28
@hdonnay hdonnay requested review from crozzy and removed request for a team September 20, 2023 23:28
@hdonnay hdonnay force-pushed the hack/config/jaeger-proto branch 2 times, most recently from 5995c03 to d9350a3 Compare September 25, 2023 18:42
@hdonnay hdonnay mentioned this pull request Sep 25, 2023
Merged
@hdonnay hdonnay force-pushed the hack/config/jaeger-proto branch 2 times, most recently from c5a2e21 to ca62579 Compare October 18, 2023 13:56
@hdonnay hdonnay mentioned this pull request Oct 18, 2023
Merged
crozzy
crozzy approved these changes Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@crozzy crozzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to undraft the related PRs when they're ready for review

@hdonnay
config: add OTLP configuration types
33cc3e5 
Signed-off-by: Hank Donnay <hdonnay@redhat.com>
@hdonnay hdonnay merged commit 33cc3e5 into quay:main Oct 27, 2023
13 checks passed
@hdonnay hdonnay deleted the hack/config/jaeger-proto branch October 30, 2023 19:11
@hdonnay hdonnay added this to the config/v1.4.0 milestone Oct 30, 2023
@hdonnay hdonnay removed the config/minor-version Merging this requires the next release to be a minor version increment. label Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crozzy crozzy crozzy approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
config/v1.4.0
Development

Successfully merging this pull request may close these issues.

config: lint for jaeger protocol & support for OTLP export
2 participants
@hdonnay @crozzy