Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

functions/package: change values for PKG_VERSION_xxx constants #132

Open
jouvin opened this issue Nov 21, 2016 · 1 comment
Open

functions/package: change values for PKG_VERSION_xxx constants #132

jouvin opened this issue Nov 21, 2016 · 1 comment
Labels
backwards incompatible

Comments

@jouvin
Copy link
Contributor

jouvin commented Nov 21, 2016

Current values are rather misleading/counter-intuitive. And they don't allow to do a numeric comarison like:

if ( pkg_compare_version('x', '1.6.0') <= PKG_VERSION_EQUAL ) ...

to test if a version is less or equal.

This should not be a problem to define less=-1 and greater=1 when all the PRs related to pkg_compare_version() have been merged. We just need to tell site to update their local templates if they use this function.
@jouvin jouvin added this to the 16.12 milestone Nov 21, 2016
@jouvin jouvin mentioned this issue Nov 22, 2016
Merged
@jrha jrha modified the milestones: 17.2, 16.12 Dec 1, 2016
@jrha jrha removed this from the 17.2 milestone Feb 10, 2017
@jrha
Copy link
Member

jrha commented Feb 10, 2017

Assign a new milestone if and when a PR exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backwards incompatible
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jrha @jouvin