Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ncm-cdispd does not refresh $last_ncd_status during main_loop #55

Open
ned21 opened this issue May 5, 2021 · 0 comments
Open

ncm-cdispd does not refresh $last_ncd_status during main_loop #55

ned21 opened this issue May 5, 2021 · 0 comments
Labels
Milestone

Comments

@ned21
Copy link
Contributor

ned21 commented May 5, 2021

I noticed that ncm-cdispd was running all dispatched components every time a new profile was received, and not just the changed sub-trees. I think there's a bug here:

    my $last_ncd_status = init_components();
    ...
    while (1) {
        main_loop($cm, $last_ncd_status, $ref_cid);
    }

Since this is a local not global variable, the $last_ncd_status is set when ncm-dispd starts up and is never changed. The fix is to make it a global variable that can be modified within the main_loop sub.

@ned21 ned21 added the bug label May 5, 2021
@jrha jrha added this to the 21.6 milestone May 14, 2021
@jrha jrha modified the milestones: 21.12, 22.2 Dec 17, 2021
@jrha jrha modified the milestones: 23.6, 23.next Jun 23, 2023
@jrha jrha modified the milestones: 23.9, 23.next Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants