ncm-pbsserver module cannot fill the /var/torque/server_priv/nodes when the file is empty

[Pansanel]

When installing a new pbs-server, the /var/torque/server_priv/nodes file provided by the RPM is empty. As you can see on the following part of the code:
https://github.com/quattor/configuration-modules-grid/blob/master/ncm-pbsserver/src/main/perl/pbsserver.pm#L279
if the file is empty, the part of the code in charge of filling the file is not executed.
Another thing, if the file is missing, it is not created. Is there a good reason for that?

[stdweird]

@Pansanel that part of the code does not fill the nodes file (or reads it). ncm-pbsserver doesn't touch the nodes file directly, it parses output from pbsnodes -a and uses qmgr to add/change nodes.
I remember an issue with older torque versions that qmgr didn't flush the state set in qmgr to the nodes file, but that was a bug in torque, not the component.

[Pansanel]

In fact, the /var/torque/nodes files is filled with the command on line 317:
$self->runCommand($qmgr, "create node $node") unless (defined($existingnodes{$node}));
However, it works only if the $existingnodes{$node} variable is set. This is done in the previous block, that is skipped if the /var/torque/nodes file is empty

[stdweird]

@Pansanel a node is only created if it didn't not exist before. not sure what is wrong with that (if they already exist, they are updated, not recreated).

[stdweird]

@Pansanel is this still an issue? if so, can you give the torque version you are seeing this with?

[Pansanel]

I have this issue with torque-server-2.5.13.