Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ncm-nmstate: VLAN name pattern too restrictive #1678

Open
jouvin opened this issue Apr 16, 2024 · 1 comment · May be fixed by #1679
Open

ncm-nmstate: VLAN name pattern too restrictive #1678

jouvin opened this issue Apr 16, 2024 · 1 comment · May be fixed by #1679
Assignees
@aka7

Comments

@jouvin
Copy link
Contributor

jouvin commented Apr 16, 2024 •
edited

ncm-nmstate changes in #1667 recognizes as a VLAN any interface whose name starts with vlan but imposes a . before the VLAN ID, despite it is not an OS or nmstate requirement.
jouvin added a commit to jouvin/configuration-modules-core that referenced this issue Apr 16, 2024
@jouvin
ncm-nmstate: relax VLAN name pattern
c30b80b 
- Does not require a . between interface name and VLAN ID

Fixes quattor#1678
jouvin added a commit to jouvin/configuration-modules-core that referenced this issue Apr 16, 2024
@jouvin
ncm-nmstate: relax VLAN name pattern
a7b41d5 
- Does not require a . between interface name and VLAN ID

Fixes quattor#1678
jouvin added a commit to jouvin/configuration-modules-core that referenced this issue Apr 16, 2024
@jouvin
ncm-nmstate: relax VLAN name pattern
122dd65 
- Does not require a . between interface name and VLAN ID

Fixes quattor#1678
@jouvin jouvin linked a pull request Apr 16, 2024 that will close this issue
Open
jouvin added a commit to jouvin/configuration-modules-core that referenced this issue Apr 16, 2024
@jouvin
ncm-nmstate: relax VLAN name pattern
4f4c11c 
- Does not require a . between interface name and VLAN ID

Fixes quattor#1678
jouvin added a commit to jouvin/configuration-modules-core that referenced this issue Apr 16, 2024
@jouvin
ncm-nmstate: relax VLAN name pattern
8dfd32d 
- Does not require a . between interface name and VLAN ID

Fixes quattor#1678
@jrha
Copy link
Member

jrha commented Apr 18, 2024

I believe that the kernel no-longer has any restriction other on interface naming other than being 15 characters or less, so we are free to follow any convention we can agree on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aka7 aka7

Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ncm-nmstate: relax syntax of VLAN interface names jouvin/configuration-modules-core
3 participants
@jrha @jouvin @aka7