Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not much comments in code. #168

Open
markyen001 opened this issue Jan 16, 2023 · 2 comments
Open

Not much comments in code. #168

markyen001 opened this issue Jan 16, 2023 · 2 comments

Comments

@markyen001
Copy link

markyen001 commented Jan 16, 2023

Dear @cclauss

Thank you for sharing this code! I understand the theory that is written in the paper, so now I've been trying to go through the code line by line to understand how the theory is implemented. However, there aren't many comments, so it's difficult to understand what most of the code is doing. I've been trying to put in comments wherever possible. Do you have a version of the code with detailed comments? Or perhaps some kind of documentation that explains how the functions work? Any help would be greatly appreciated!

Furthermore, the code makes a bunch of copies of the same scripts in different directories. I can't tell if there are any differences between each copy of scripts.

Thank you so much for your time and have a wonderful day!

@cclauss
Copy link
Contributor

cclauss commented Jan 18, 2023

I am not the author of this code. I assume that @quark0 is.

Currently, the code has 5 easy to fix Syntax Errors when running on modern Python versions. Just change async to non_blocking in each instance below.

flake8 . --count --select=E9,F63,F7,F82,Y --show-source --statistics
./cnn/test.py:85:52: E999 SyntaxError: invalid syntax
    target = Variable(target, volatile=True).cuda(async=True)
                                                   ^
./cnn/test_imagenet.py:94:52: E999 SyntaxError: invalid syntax
    target = Variable(target, volatile=True).cuda(async=True)
                                                   ^
./cnn/train.py:119:37: E999 SyntaxError: invalid syntax
    target = Variable(target).cuda(async=True)
                                    ^
./cnn/train_imagenet.py:176:27: E999 SyntaxError: invalid syntax
    target = target.cuda(async=True)
                          ^
./cnn/train_search.py:140:58: E999 SyntaxError: invalid syntax
    target = Variable(target, requires_grad=False).cuda(async=True)
                                                         ^
5     E999 SyntaxError: invalid syntax
5

@markyen001
Copy link
Author

Dear @quark0

Do you happen to have any documentation about how each function is properly used? Any help would be appreciated! Thank you so much!

Mark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants