Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate extra requirements for specific experiments #231

Open
mpharrigan opened this issue Nov 12, 2021 · 0 comments
Open

Separate extra requirements for specific experiments #231

mpharrigan opened this issue Nov 12, 2021 · 0 comments
Labels

Comments

@mpharrigan
Copy link
Collaborator

Right now: requirements are "best effort" separated in a single requirements.txt file by arranging them under comment-headings for the various sub-packages

We could use pip's support for extras-require, e.g. pip install recirq[qaoa] so the extra requirements could be specified in a structured way. Specifically: I propose an extra-requirements.txt file in each submodule (i.e. experiment) containing that sub-packages extra requirements. These files could be parsed in setup.py to generate the extras_require argument to setuptools.setup.

Currently our notebooks pip install +github.com/quantumlib/recirq so that they work in a colab environment. We'll need to do the change stepwise to make sure the notebooks don't break

  1. add extra_requires but don't remove those requirements from install_requires
  2. update notebooks to pip install recirq with requisite extras, i.e. pip install +github/recirq[qaoa]
  3. Remove the extra requirements from install_requires so pip install recirq only gets you the minimal, base requirements.

cc @dstrain115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant