Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fermi_hubbard publication_test is not hermetic #165

Open
weinstein opened this issue Apr 26, 2021 · 1 comment · May be fixed by #171
Open

fermi_hubbard publication_test is not hermetic #165

weinstein opened this issue Apr 26, 2021 · 1 comment · May be fixed by #171

Comments

@weinstein
Copy link
Contributor

it downloads datasets from https://datadryad.org/stash/dataset/doi:10.5061/dryad.crjdfn32v
the download URLs are not super stable, but also datadryad.org website unavailability can cause the recirq test suites to flake out and fail

It may be better to avoid the external dependency on datadryad.org in tests and mock out the download.

@rmlarose
Copy link
Contributor

rmlarose commented May 5, 2021

Documenting discussion with the helpful folks at Dryad:

Our team has confirmed that individual files do not have their own unique link. Previously, the did but that was changed with the relaunch in 2019.

So a permanent fix should use the DOI of the dataset instead of URLs for individual files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants