Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hfvqe/molecular_data should not be distributed with the package #101

Open
mpharrigan opened this issue Nov 20, 2020 · 1 comment
Open

hfvqe/molecular_data should not be distributed with the package #101

mpharrigan opened this issue Nov 20, 2020 · 1 comment
Labels
hfvqe

Comments

@mpharrigan
Copy link
Collaborator

mpharrigan commented Nov 20, 2020 •
edited

Following data (collection) idioms, there should be a task to generate this data into ~/cirq-results/ and then subsequent code can consume it from there. We should also upload a copy of it to a figshare dataset for fetching during tutorials / testing.

cc @ncrubin
@mpharrigan
Copy link
Collaborator Author

There's currently a "bug" where if you pip install recirq, it can't find the data files because they're not installed. A quick fix would be to add the data directory to setup.py's package_data field.

mpharrigan added a commit to mpharrigan/ReCirq that referenced this issue Nov 20, 2020
@mpharrigan
Install dependencies and format hfvqe/quickstart
6ce74ab 
Partially address quantumlib#101. Re-work `molecular_exmaple.py` to
support putting these data files elsewhere in the future.
@mpharrigan mpharrigan mentioned this issue Nov 20, 2020
Merged
mpharrigan added a commit to mpharrigan/ReCirq that referenced this issue Nov 20, 2020
@mpharrigan
Install dependencies and format hfvqe/quickstart
b5e707f 
Partially address quantumlib#101. Re-work `molecular_exmaple.py` to
support putting these data files elsewhere in the future.
mpharrigan added a commit to mpharrigan/ReCirq that referenced this issue Nov 20, 2020
@mpharrigan
Install dependencies and format hfvqe/quickstart
4945d91 
Partially address quantumlib#101. Re-work `molecular_exmaple.py` to
support putting these data files elsewhere in the future.
mpharrigan added a commit that referenced this issue Nov 30, 2020
@mpharrigan
Install dependencies and format hfvqe/quickstart (#102)
c873c64 
* Install dependencies and format hfvqe/quickstart

Partially address #101. Re-work `molecular_exmaple.py` to
support putting these data files elsewhere in the future.

* Spruce up headings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hfvqe
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mpharrigan