Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some inconsistencies in molecular single factorization costings #838

Closed
fdmalone opened this issue Oct 16, 2023 · 1 comment
Closed

Some inconsistencies in molecular single factorization costings #838

fdmalone opened this issue Oct 16, 2023 · 1 comment
Assignees
@fdmalone
Labels
bug

Comments

@fdmalone
Copy link
Collaborator

fdmalone commented Oct 16, 2023 •
edited

the variable nprime has the second term divided by 4 instead of 2

OpenFermion/src/openfermion/resource_estimates/sf/compute_cost_sf.py

Line 72 in a034397

nprime = int(n**2 // 8 + n // 4)
as per eq. B13.

The inverse QROM should be on two registers (QI2) not one (QI).
@fdmalone fdmalone mentioned this issue Oct 17, 2023
Closed
@fdmalone fdmalone self-assigned this Oct 17, 2023
@fdmalone fdmalone added the bug label Oct 17, 2023
@fdmalone fdmalone changed the title Some inconsistencies in single molecular single factorization costings Some inconsistencies in molecular single factorization costings Nov 12, 2023
This was referenced Nov 20, 2023
Closed
Merged
@fdmalone
Copy link
Collaborator Author

fdmalone commented Nov 21, 2023 •
edited

Looking again more closely, B19 is actually a typo, the amount of data is N/2*(N/2 + 1) / 2 = N^2/8 + N/4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fdmalone fdmalone

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fdmalone