Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inequality comparison issue using <> #1347

Merged
merged 6 commits into from
May 23, 2024

Conversation

AyushAgrawal-A2
Copy link
Contributor

closes #1328

Changes:

  • Updated regex to match <> as well

image

image

Copy link

cla-bot bot commented May 12, 2024

We require contributors to sign our Contributor License Agreement, and we don"t have one on file for you. In order for us to review and merge your code, please contact our team at https://www.quadratichq.com/contact.

Copy link

vercel bot commented May 12, 2024

@AyushAgrawal-A2 is attempting to deploy a commit to the Quadratic Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

cla-bot bot commented May 12, 2024

We require contributors to sign our Contributor License Agreement, and we don"t have one on file for you. In order for us to review and merge your code, please contact our team at https://www.quadratichq.com/contact.

@ddimaria
Copy link
Collaborator

I checked and there are tests already associated with this feature, so not sure why they were passing 🤔

I validate the UI and confirmed the issue is fixed.

Copy link
Collaborator

@ddimaria ddimaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @AyushAgrawal-A2!

Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.34%. Comparing base (b77959e) to head (9e0d68e).

Current head 9e0d68e differs from pull request most recent head 05674cc

Please upload reports for the commit 05674cc to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1347      +/-   ##
==========================================
+ Coverage   89.24%   89.34%   +0.10%     
==========================================
  Files         160      160              
  Lines       26552    26425     -127     
==========================================
- Hits        23696    23610      -86     
+ Misses       2856     2815      -41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidkircos davidkircos merged commit 47ce571 into quadratichq:main May 23, 2024
8 of 11 checks passed
@AyushAgrawal-A2 AyushAgrawal-A2 deleted the ayush/1328 branch May 23, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inequality comparison issue using <> logic
3 participants