metadata function for QAdd

[oameye]

The package defines a function to extract the metadata of the QAdd type but QAdd does not have a metadata field.

QuantumCumulants.jl/src/qnumber.jl

Line 232 in 1d144b1

SymbolicUtils.metadata(q::QAdd) = q.metadata

The function is used when you try to use Symbolics.expand on a QAdd expression:

using QuantumCumulant
using Symbolics

h = FockSpace(:cavity)

@qnumbers a::Destroy(h)

expr = (a'+a) |> simplify
expr |> expand

[david-pl]

Thanks for the report! The fact that the metadata is missing here is definitely an oversight on our end. However, that's not the whole story. I wouldn't expect expand to work properly on QNumber types right now. What we also need is an overload to expand similar to what we are doing with simplify so Symbolics can work on numbers. Something like this:

function Symbolics.expand(q::QTerm)
    q |> average |> expand |> undo_average
end