npm run test fails on windows

[bessorion]

I tried to run tests on Win 10, nvm 8.11.1:
C:\Users\BeSSoRioN\Documents\GitHub\qmlweb>npm run test

Result output you can see below. remark command return exit status 1 because of warnings, so test procedure fails on remark -qf *.md docs:

> qmlweb@0.2.0 test C:\Users\BeSSoRioN\Documents\GitHub\qmlweb
> npm run lint && gulp test

> qmlweb@0.2.0 lint C:\Users\BeSSoRioN\Documents\GitHub\qmlweb
> npm run eslint && npm run mdlint

> qmlweb@0.2.0 eslint C:\Users\BeSSoRioN\Documents\GitHub\qmlweb
> eslint --cache *.js src tests builder

> qmlweb@0.2.0 mdlint C:\Users\BeSSoRioN\Documents\GitHub\qmlweb
> remark -qf *.md docs

CONTRIBUTING.md
43:82 warning Line must be at most 80 characters maximum-line-length remark-lint
45:82 warning Line must be at most 80 characters maximum-line-length remark-lint
93:82 warning Line must be at most 80 characters maximum-line-length remark-lint
123:82 warning Line must be at most 80 characters maximum-line-length remark-lint
124:82 warning Line must be at most 80 characters maximum-line-length remark-lint
142:82 warning Line must be at most 80 characters maximum-line-length remark-lint
237:82 warning Line must be at most 80 characters maximum-line-length remark-lint
245:82 warning Line must be at most 80 characters maximum-line-length remark-lint

README.md
40:82 warning Line must be at most 80 characters maximum-line-length remark-lint
143:82 warning Line must be at most 80 characters maximum-line-length remark-lint
154:82 warning Line must be at most 80 characters maximum-line-length remark-lint

docs\QMLEngine.md
69:82 warning Line must be at most 80 characters maximum-line-length remark-lint
118:82 warning Line must be at most 80 characters maximum-line-length remark-lint

docs\Signal.md
32:82 warning Line must be at most 80 characters maximum-line-length remark-lint

‼ 14 warnings
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! qmlweb@0.2.0 mdlint: 'remark -qf *.md docs && exit 0'
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the qmlweb@0.2.0 mdlint script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR! C:\Users\BeSSoRioN\AppData\Roaming\npm-cache\_logs\2018-05-02T22_53_04_267Z-debug.log
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! qmlweb@0.2.0 lint: 'npm run eslint && npm run mdlint'
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the qmlweb@0.2.0 lint script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR! C:\Users\BeSSoRioN\AppData\Roaming\npm-cache\_logs\2018-05-02T22_53_04_329Z-debug.log
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! qmlweb@0.2.0 test: 'npm run lint && gulp test'
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the qmlweb@0.2.0 test script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR! C:\Users\BeSSoRioN\AppData\Roaming\npm-cache\_logs\2018-05-02T22_53_04_384Z-debug.log

After *.md files had been changed to resolve warnings the whole test finished successfully.

[bessorion]

I suppose it's because of encoding. Warning valid for 80-character lines (because of line-ending?)
Also some windows editors visualize symbols « » and — in wrong way, but it's not so critical.

[bessorion]

./node_modules/remark-lint/lib/rules/maximum-line-length.js

function maximumLineLength(ast, file, preferred) {
var style = preferred && preferred !== true ? preferred : 80;
var content = file.toString();
var matrix = content.split('\n');
var index = -1;
var length = matrix.length;
var lineLength;

And I see via Hex-editor 0D0A line endings in my local files.

[ChALkeR]

@bessorion Yeah, that makes sense, thanks!
Looks like a remark-lint bug.

Will try to update to the latest version (that requires changes on QmlWeb side, see #412), if that won't fix things — will take a look at remark side.

[bessorion]

I think migration to 6.0.0 should solve problem:
https://github.com/remarkjs/remark-lint/blob/master/packages/remark-lint-maximum-line-length/index.js

function maximumLineLength(ast, file, preferred) {
  var style = preferred && preferred !== true ? preferred : 80;
  var content = file.toString();
  var matrix = content.split(/\r?\n/);

[Plaristote]

We migrated remark-lint to 9.1.0 (time flies, doesn't it) ! I assume the issue has been resolved ?