Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] qmk setup can't handle spaces in home path #23098

Open
2 tasks
Nobodi99 opened this issue Feb 16, 2024 · 2 comments
Open
2 tasks

[Bug] qmk setup can't handle spaces in home path #23098

Nobodi99 opened this issue Feb 16, 2024 · 2 comments

Comments

@Nobodi99
Copy link

Describe the Bug

I was just upgrading to the external userspace and had to update my qmk config because I couldn't get the userspace-add command to work.

I then saw this line in my config:
user.qmk_home=S:ProjectsKeyboardsQMK

This was really weird and I tried to run qmk setup again but it set it to the above so I had to set it manually.
I had to set the path sorrounded with "" to set it to:
user.qmk_home=S:/Projects/Keyboards/QMK Firmware/qmk_firmware

After setting it manually it finally works.
I would expect that qmk setup would set the path correctly even if it contains a space.
Sadly I don't know enough about the build code to do any PR for it :)

Keyboard Used

No response

Link to product page (if applicable)

No response

Operating System

Windows

qmk doctor Output

No response

Is AutoHotKey / Karabiner installed

  • AutoHotKey (Windows)
  • Karabiner (macOS)

Other keyboard-related software installed

No response

Additional Context

No response

@tzarc
Copy link
Member

tzarc commented Feb 17, 2024

QMK builds won't work on paths with spaces regardless. It's an issue with GNU Make and not something we can fix.

@Nobodi99
Copy link
Author

QMK builds won't work on paths with spaces regardless. It's an issue with GNU Make and not something we can fix.

I can compile the firmware after setting the path like this. And I never had any problem compiling before this change to external userspaces.
I do run into the problem that it can't save the uf2 file to the userspace folder now because the userspace is in another folder with a space in it and somehow it cuts of everything before the space.
Would you happen to know which repository I could look into for that?
(The uf2 file is succesfully created in the .build folder of the main repo though)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants