This is similar to #1304.

I don't much use Application or Desktop, so I didn't notice that this could be a regression.
Good point.

Can you create a test in .../pywinauto/unittests/test_application.py that passes in 0.6.8 and fails in atspi@bf7f789?

If possible, it would be desirable to use a test GUI from .../apps instead of notepad.exe, as the names may change depending on the language of the execution environment.

I plan to investigate this next week during weekdays and make any necessary changes to the production code or add test code if needed.

However, those who frequently use Application or Desktop might come up with more suitable use cases for testing.

Any opinions would be appreciated.

This is not a situation where Application.window "became uncallable" or "lost the ability to take any keyword arguments". Rather, it should be viewed as a situation where "the acceptable keyword arguments have changed".

In #848, significant changes were made where title_re and title were replaced with name_re and name, and tests were also updated in 22ba132.

• For example...
  • 0.6.8

    pywinauto/pywinauto/unittests/test_application.py

    Lines 641 to 667 in ff95296

    	def test_window(self):
    	"""Test that window_() works correctly"""
    	app = Application()
    	self.assertRaises(AppNotConnected, app.window_, **{'title' : 'not connected'})
    	app.start(_notepad_exe())
    	self.assertRaises(ValueError, app.windows_, **{'backend' : 'uia'})
    	title = app.window_(title = "Untitled - Notepad")
    	title_re = app.window_(title_re = "Untitled[ -]+Notepad")
    	classname = app.window_(class_name = "Notepad")
    	classname_re = app.window_(class_name_re = "Not..ad")
    	handle = app.window_(handle = title.handle)
    	bestmatch = app.window_(best_match = "Untiotled Notepad")
    	self.assertNotEqual(title.handle, None)
    	self.assertNotEqual(title.handle, 0)
    	self.assertEqual(title.handle, title_re.handle)
    	self.assertEqual(title.handle, classname.handle)
    	self.assertEqual(title.handle, classname_re.handle)
    	self.assertEqual(title.handle, handle.handle)
    	self.assertEqual(title.handle, bestmatch.handle)
    	app.UntitledNotepad.menu_select("File->Exit")

  • atspi@bf7f789

    pywinauto/pywinauto/unittests/test_application.py

    Lines 640 to 666 in bf7f789

    	def test_window(self):
    	"""Test that window_() works correctly"""
    	app = Application()
    	self.assertRaises(AppNotConnected, app.window_, **{'title' : 'not connected'})
    	app.start(_notepad_exe())
    	self.assertRaises(ValueError, app.windows_, **{'backend' : 'uia'})
    	title = app.window(name="Untitled - Notepad")
    	title_re = app.window(name_re="Untitled[ -]+Notepad")
    	classname = app.window(class_name="Notepad")
    	classname_re = app.window(class_name_re="Not..ad")
    	handle = app.window(handle=title.handle)
    	bestmatch = app.window(best_match="Untiotled Notepad")
    	self.assertNotEqual(title.handle, None)
    	self.assertNotEqual(title.handle, 0)
    	self.assertEqual(title.handle, title_re.handle)
    	self.assertEqual(title.handle, classname.handle)
    	self.assertEqual(title.handle, classname_re.handle)
    	self.assertEqual(title.handle, handle.handle)
    	self.assertEqual(title.handle, bestmatch.handle)
    	app.UntitledNotepad.menu_select("File->Exit")

@vasily-v-ryabov
Should we consider adding a workaround for developers who were previously using title_re or title?
Edited: I think I found the possible cause of the problem.

It might be necessary to have a warning message conveying that "argument names should be updated to the new ones" as well.

I didn't notice it just by looking at Application, but while looking at the findwindows side, I think I found the possible cause of the problem.

There is an implementation in find_windows that swaps keywords based on *ElementInfo.renamed_props, but it seems to not be working correctly.

I'm considering making changes to the production code and adding tests, and if it seems to work well, I'll submit a PR.

I'd also like to mention that backward compatibility was restored in #1253.