Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpu version int_nbit_split_embedding_codegen_lookup_function not support indices and offsets with uint64 dtype #1830

Open
tiankongdeguiji opened this issue Mar 27, 2024 · 3 comments

Comments

@tiankongdeguiji
Copy link

This PR removes uint32 indices protection in quant/embedding_modules.py. Nevertheless, when indices and offsets inputs of uint64 dtype are provided, int_nbit_split_embedding_codegen_lookup_function triggers a RuntimeError: expected scalar type Int but found Long on the GPU. Would it be possible to add support for the uint64 dtype on GPU devices?

@PaulZhang12
Copy link
Contributor

It what cases would it be necessary to use uint64?

@tiankongdeguiji
Copy link
Author

It what cases would it be necessary to use uint64?

In certain scenarios, the uint32 data type is insufficient to contain the indices for user_id and several combo feature.

@spcyppt
Copy link

spcyppt commented May 13, 2024

@tiankongdeguiji Hi, let me bring this to the FBGEMM team's attention and get back to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants