New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EmbeddingBagCollection is not allowed to set embedding_dim=1, but many model need it for WideArch #1495

Open

tiankongdeguiji opened this issue Nov 9, 2023 · 1 comment

tiankongdeguiji commented Nov 9, 2023

EmbeddingBagCollection is not allowed to set embedding_dim=1, but many models need it for WideArch, e.g. WideAndDeep, DeepFM.

AssertionError: table t_cat_9 has local_cols=1 not divisible by 4.

The text was updated successfully, but these errors were encountered:

Contributor

henrylhtsang commented Nov 13, 2023

Hi, the problem is the kernel library we use requires the dim to be divisible by 4. https://github.com/pytorch/FBGEMM/blob/2117dd33d4c4fd53cfadbf037b5fb3c0824cb00e/fbgemm_gpu/fbgemm_gpu/split_table_batched_embeddings_ops_training.py#L119

We can keep this issue open as a feature request though.

henrylhtsang mentioned this issue

assert table.local_cols % 4 == 0 #1612

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment