Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline Method refactoring is allowed in abstract methods. #744

Open
jonhnanthan opened this issue Jan 15, 2024 · 0 comments
Open

Inline Method refactoring is allowed in abstract methods. #744

jonhnanthan opened this issue Jan 15, 2024 · 0 comments
Labels
bug Unexpected or incorrect user-visible behavior inline-refactor

Comments

@jonhnanthan
Copy link

jonhnanthan commented Jan 15, 2024

Abstract methods do not have an implementation in the class where they are declared; their implementation is expected to be provided by concrete subclasses.
It would be nice if Rope emitted a warning.

Steps to reproduce the behavior:

  1. Code before refactoring:
from abc import abstractmethod


class Base:

    @abstractmethod
    def tag(self, text, tokenize=True):
        return
  1. Apply the Inline Method refactoring to Base.tag().
@jonhnanthan jonhnanthan added the bug Unexpected or incorrect user-visible behavior label Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected or incorrect user-visible behavior inline-refactor
Projects
None yet
Development

No branches or pull requests

2 participants