Fix smart strip turn on and turn off when no arguments are given in the CLI #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #639 +/- ##
=======================================
Coverage 86.59% 86.59%
=======================================
Files 38 38
Lines 3490 3492 +2
Branches 893 895 +2
=======================================
+ Hits 3022 3024 +2
Misses 384 384
Partials 84 84 ☔ View full report in Codecov by Sentry. |
|
The current implementation works at least on my KP303, and my understanding was that it would work on other multi-socket devices. Doing this would cause extra I/O on those devices, so I'm wondering if this is just an issue with your specific hw/fw. @bdraco, does this work currently on your HS300? |
rytilahti
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't break turning on and off individual plugs which are gotten with
get_plug_by_indexorget_plug_by_name.This change is verified working on a real HS300 with hardware version 2.0 and firmware version 1.0.12.
Fixes #637