[WIP] Kasa Cam support #537

bstrdsmkr · 2023-10-30T15:52:49Z

Supports controlling Kasa Cam devices such as the EC70(US)

Closes #530

codecov · 2023-10-31T16:08:27Z

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Files	Coverage Δ
kasa/__init__.py	`100.00% <100.00%> (ø)`
kasa/cli.py	`58.77% <ø> (ø)`
kasa/discover.py	`86.47% <100.00%> (+1.40%)`	⬆️
kasa/modules/__init__.py	`100.00% <100.00%> (ø)`
kasa/modules/time.py	`93.10% <100.00%> (+1.43%)`	⬆️
kasa/protocol.py	`88.88% <100.00%> (+0.88%)`	⬆️
kasa/smartcamera.py	`100.00% <100.00%> (ø)`
kasa/smartdevice.py	`87.92% <100.00%> (+0.13%)`	⬆️
kasa/modules/ptz.py	`94.11% <94.11%> (ø)`
kasa/smartcameraprotocol.py	`83.33% <83.33%> (ø)`

📢 Thoughts on this report? Let us know!

rytilahti

Thanks for the PR, @bstrdsmkr! I added some initial review comments inline.

kasa/__init__.py

kasa/kasacamprotocol.py

kasa/modules/module.py

kasa/modules/ptz.py

kasa/kasacamera.py

kasa/kasacamprotocol.py

kasa/protocol.py

rytilahti · 2023-10-31T18:21:45Z

kasa/smartdevice.py

@@ -379,7 +386,7 @@ def update_from_discover_info(self, info: Dict[str, Any]) -> None:

    def _set_sys_info(self, sys_info: Dict[str, Any]) -> None:
        """Set sys_info."""
-        self._sys_info = sys_info
+        self._sys_info = sys_info if "model" in sys_info else sys_info["system"]


Add a quick command why this is done.

I saw you did check earlier if the key system is inside the sysinfo, this probably should do the same for consistency?

This was buried, so just a friendly ping :-)

devtools/dump_devinfo.py

kasa/__init__.py

kasa/kasacamera.py

kasa/modules/ptz.py

kasa/smartdevice.py

kasa/tests/conftest.py

kasa/smartdevice.py

rytilahti · 2023-11-07T01:00:48Z

kasa/smartdevice.py

@@ -379,7 +386,7 @@ def update_from_discover_info(self, info: Dict[str, Any]) -> None:

    def _set_sys_info(self, sys_info: Dict[str, Any]) -> None:
        """Set sys_info."""
-        self._sys_info = sys_info
+        self._sys_info = sys_info if "model" in sys_info else sys_info["system"]


I saw you did check earlier if the key system is inside the sysinfo, this probably should do the same for consistency?

bstrdsmkr · 2023-11-09T15:45:57Z

@rytilahti the ptz stuff is most of what I personally care about for this but I've pulled a

List of known commands from the android app

# smartlife.cam.ipcamera.audio
async def get_mic_config(self):
    # , volume:int
    pass

async def get_quickres_list(self):
    # , files:list, max_files:int
    return await self.call("smartlife.cam.ipcamera.audio", "get_quickres_list", {})

async def set_chime(self, duration: int):
    pass

async def set_mic_config(self, volume: int):
    pass

async def set_quickres_off(self):
    pass

async def set_quickres_state(self, file_id: int, repeat: int):
    pass

# smartlife.cam.ipcamera.battery

async def get_power_save(self):
    pass

async def get_status(self):
    # public Integer battery_capacity;
    # public String battery_charging;
    # public Boolean battery_installed;
    # public String battery_model;
    # public Integer battery_percent;
    # public Integer battery_temperature;
    # public String battery_vendor;
    # public Integer battery_voltage;
    # public Boolean low_battery;
    # public String power_mode;
    pass

async def set_power_save(self):
    pass

# smartlife.cam.ipcamera.siren

async def get_config(self):
    # public Integer duration;
    # public Boolean enable;
    # public Integer volume;
    return await self.call("smartlife.cam.ipcamera.siren", "get_config", {})

async def get_state(self):
    # public Integer time_left;
    # public String value;
    pass

async def set_config(self, duration: int, enable: bool, volume: int):
    pass

async def set_state(self, state: str):
    pass

async def set_state_with_duration(self, state: str, duration: int):
    pass

# smartlife.cam.ipcamera.switch
async def get_is_enable(self):
    pass

async def set_is_enable(self, enabled: bool):
    pass

# smartlife.cam.ipcamera.cloud

async def get_info(self):
    # public Boolean binded;
    # public Boolean cld_connection;
    # public String default_svr;
    # public String fw_dl_page;
    # public Integer fw_notify_type;
    # public Integer illegal_type;
    # public String sef_domain;
    # public Integer stop_connect;
    # public String tcsp_info;
    # public Integer tcsp_status;
    # public String username;
    return await self.call("smartlife.cam.ipcamera.cloud", "get_info", {})

async def set_server_url(self):
    # Deprecated
    pass

async def set_n_server_url(self):
    # public String default_svr;
    # public String ipcserv_svr;
    # public String sef_domain
    pass

async def set_bind(self):
    pass

async def set_unbind(self, username: str, password: str):
    pass

# smartlife.cam.ipcamera.dateTime

async def get_status(self):
    pass

async def get_time(self):
    # public Long epoch_sec;
    pass

async def get_time_zone(self):
    # public String area;
    # public String timezone;
    pass

async def set_time(self, epoch_sec: int, mode: str):
    pass

async def set_time_zone(self, area: str, timezone: str):
    pass

# smartlife.cam.ipcamera.dayNight

async def get_force_lamp_state(self):
    pass

async def get_force_lamp_time(self):
    pass

async def get_lamp_status(self):
    # public Integer forcetime;
    # public String value;
    pass

async def get_mode(self):
    pass

async def get_night_vision_mode(self):
    pass

async def set_force_lamp_state(self):
    pass

async def set_force_lamp_time(self):
    pass

async def set_mode(self):
    pass

async def set_night_vision_mode(self):
    pass

# smartlife.cam.ipcamera.debug

async def set_http_server_switch(self):
    # public String av;
    # public String httpd;
    pass

# smartlife.cam.ipcamera.delivery

async def get_clip_audio_is_enable(self):
    pass

async def get_local_clip_is_enable(self):
    return await self.call(
        "smartlife.cam.ipcamera.delivery", "get_local_clip_is_enable", {}
    )

async def set_clip_audio_is_enable(self):
    pass

async def set_local_clip_is_enable(self):
    pass

# smartlife.cam.ipcamera.dndSchedule

async def add_rule(self):
    pass

async def delete_rule(self):
    pass

async def edit_rule(self):
    pass

async def get_dnd_enable(self):
    pass

async def get_rules(self):
    pass

async def set_dnd_enable(self):
    pass

# smartlife.cam.ipcamera.intelligence

async def get_all_pd_area(self):
    pass

async def get_bcd_enable(self):
    pass

async def get_bcd_sensitivity_level(self):
    pass

async def get_pd_area(self):
    # public List area;
    # public Integer max;
    # public Integer viewpoint
    pass

async def get_pd_enable(self):
    pass

async def get_pd_sensitivity_level(self):
    # public Integer day_mode_level;
    # public Integer night_mode_level
    pass

async def set_bcd_enable(self):
    pass

async def set_bcd_sensitivity_level(self):
    pass

async def set_pd_area(self, area: list, viewpoint: int):
    pass

async def set_pd_enable(self):
    pass

async def set_pd_sensitivity_level(
    self, day_mode_level: int, night_mode_level: int
):
    pass

# smartlife.cam.ipcamera.led

async def get_buttonled_status(self):
    pass

async def set_buttonled_status(self):
    pass

async def set_status(self):
    pass

async def get_status(self):
    pass

# smartlife.cam.ipcamera.motionDetect

async def get_detect_area(self):
    # public List area;
    # public Integer max;
    # public Integer viewpoint;
    pass

async def get_is_enable(self):
    pass

async def get_min_trigger_time(self):
    # public Integer day_mode_value;
    # public Integer night_mode_value;
    pass

async def get_sensitivity(self):
    pass

async def get_sensitivity_level(self):
    # public Integer day_mode_level;
    # public Integer night_mode_level;
    pass

async def set_detect_area(self, area: list, viewpoint: int):
    pass

async def set_is_enable(self):
    pass

async def set_min_trigger_time(self, day_mode_level: int, night_mode_level: int):
    pass

async def set_sensitivity(self):
    pass

async def set_sensitivity_level(self, day_mode_level: int, night_mode_level: int):
    pass

# smartlife.cam.ipcamera.OSD

async def get_logo_is_enable(self):
    pass

async def get_time_is_enable(self):
    pass

async def set_logo_is_enable(self):
    pass

async def set_time_is_enable(self):
    pass

# smartlife.cam.ipcamera.ptz

async def add_preset(self):
    # public String api_srv_url;
    # public Integer index;
    # public String name;
    # public String path;
    # public Integer wait_time;
    pass

async def delete_preset(self, index: int):
    pass

async def edit_preset(self, index: int, name: str, wait_time: int):
    pass

async def get_all_preset(self):
    # public Integer maximum;
    # public List preset_attr;
    pass

async def get_patrol_is_enable(self):
    pass

async def get_position(self):
    # public Integer x;
    # public Integer y;
    pass

async def get_ptz_rectify_state(self):
    pass

async def get_ptz_tracking_is_enable(self):
    pass

async def set_motor_rectify(self):
    pass

async def set_move(self, x: int, y: int):
    pass

async def set_patrol_is_enable(self):
    pass

async def set_ptz_tracking_is_enable(self):
    pass

async def set_run_to_preset(self, index: int):
    pass

async def set_stop(self):
    pass

async def set_target(self, direction: str, speed: int):
    pass

# smartlife.cam.ipcamera.relay

async def get_preview_snapshot(self):
    # public String api_srv_url;
    # public String path;
    # public String timestamp;
    pass

async def set_frame_type(self, frame_type: str):
    pass

async def set_prepare_relay(
    self,
    audio_type: str,
    cookie: str,
    frame_type: str,
    max_video_res: str,
    player_id: str,
    record_preview: int,
    resolution: str,
    start_time: int,
    stream_url: str,
    type: str,
    video_type: str,
):
    pass

# smartlife.cam.ipcamera.rtp

async def set_prepare_rtc_session(self, sessionId: str, speaker_occupied: bool):
    pass

async def set_rtc_session_status(
    self, connected: bool, sessionId: str, speaker_occupied: bool
):
    pass

# smartlife.cam.ipcamera.camSchedule

async def add_rule(self):
    pass

async def delete_all_rules(self):
    pass

async def delete_rule(self, id: str):
    pass

async def edit_rule(self):
    # public String conflict_id;
    # public Integer day;
    # public Integer eact;
    # public Integer emin;
    # public Boolean enable;
    # public Integer etime_opt;
    # public String id;
    # public Integer month;
    # public String name;
    # public Integer repeat;
    # public Integer sact;
    # public Integer smin;
    # public Integer stime_opt;
    # public List wday;
    # public Integer year;
    pass

async def get_rules(self):
    # public Boolean enable;
    # public List rule_list;
    pass

# smartlife.cam.ipcamera.sdCard

async def get_sd_enc_config(self):
    # public String sd_enc_enable;
    # public String user_key_enable;
    pass

async def get_sd_card_state(self):
    # public String detect_state;
    # public String free;
    # public String reserve_capacity;
    # public String sd_capacity;
    # public String state;
    # public String total;
    # public String used;
    pass

async def set_format_sd_card(self):
    pass

async def set_sd_enc_config(
    self, key: str, sd_enc_enable: str, user_key_enable: str
):
    pass

# smartlife.cam.ipcamera.soundDetect

async def get_is_enable(self):
    pass

async def get_sensitivity(self):
    pass

async def set_is_enable(self):
    pass

async def set_sensitivity(self):
    pass

# system

async def get_sysinfo(self):
    # public Integer a_type;
    # public String account_id;
    # public String alias;
    # public String battery_charging;
    # public Integer battery_percent;
    # public List c_opt;
    # public String camera_switch;
    # public String dev_name;
    # public String deviceId;
    # public String dnd_switch;
    # public List f_list;
    # public String hwId;
    # public String hw_ver;
    # public Long last_activity_timestamp;
    # public String mic_mac;
    # public String model;
    # public List new_feature;
    # public String oemId;
    # public Boolean online;
    # public String power;
    # public String resolution;
    # public Integer rssi;
    # public Integer stream_version;
    # public String sw_ver;
    # final LinkieCameraCommand.SysInfo this$0;
    # public String type;
    # public Boolean updating;
    pass

# smartlife.cam.ipcamera.system

async def set_alias(self):
    pass

async def set_change_local_password(self, c_opt: int, passphrase: str):
    pass

async def set_dev_location(self, lattitude: int, longitude: int):
    pass

async def set_onboarding_status(self):
    pass

async def set_reboot(self, delay_sec: int):
    pass

async def set_reset_config(self, isfullreset: bool):
    pass

# smartlife.cam.ipcamera.upgrade

async def set_download_firmware(self, flash_sec: int, reboot_sec: int):
    pass

async def get_download_status(self):
    pass

# smartlife.cam.ipcamera.upnpc

async def get_pub_ip(self):
    pass

async def get_upnp_commstatus(self):
    pass

async def get_upnp_info(self):
    return await self.call("smartlife.cam.ipcamera.upnpc", "get_upnp_info", {})

async def get_upnp_status(self):
    pass

async def set_upnp_commstatus(self, comm_status: str, desc: str, timestamp: int):
    pass

async def set_upnp_info(self, enabled: str, mode: str):
    pass

# smartlife.cam.ipcamera.videoControl

async def get_channel_quality(self):
    return await self.call(
        "smartlife.cam.ipcamera.videoControl", "get_channel_quality", {}
    )

async def get_power_frequency(self):
    pass

async def get_resolution(self):
    pass

async def get_rotation_degree(self):
    pass

async def set_channel_quality(self):
    pass

async def set_power_frequency(self):
    pass

async def set_resolution(self):
    pass

async def set_rotation_degree(self):
    pass

# smartlife.cam.ipcamera.vod

async def get_detect_event_state(self):
    pass

async def get_detect_zone_brief(self):
    pass

async def get_detect_zone_list(self):
    pass

async def get_detect_zone_range(self):
    pass

async def get_is_enable(self):
    return await self.call("smartlife.cam.ipcamera.vod", "get_is_enable", {})

async def get_playback_info(self):
    return await self.call("smartlife.cam.ipcamera.vod", "get_playback_info", {})

async def get_record_zone_brief(self):
    pass

async def get_record_zone_list(self):
    pass

async def get_record_zone_range(self):
    pass

async def get_vod_occupied_state(self):
    pass

async def reset_vod_connection(self):
    pass

async def set_download_playback(
    self, player_id: str, start_time: int, user_id: str
):
    pass

async def set_heartbeat_playback(self, player_id: str, user_id: str):
    pass

async def set_is_enable(self):
    pass

async def set_pause_playback(self, player_id: str, user_id: str):
    pass

async def set_start_playback(self, player_id: str, start_time: int, user_id: str):
    pass

# smartlife.cam.ipcamera.wireless

async def get_ap_list(self):
    pass

async def get_connect_status(self):
    pass

async def get_uplink(self):
    pass

async def set_apply_changes(self, delay: int):
    pass

async def set_start_scan(self, band: str, scan_type: str):
    pass

async def set_uplink(
    self,
    apply: bool,
    band: str,
    encryption: str,
    key_index: str,
    passphrase: str,
    ssid: str,
    wpa_mode: str,
):
    pass

I'd like to implement them eventually but don't want that to hold up this PR and likely won't have time for a bit. What are your thoughts on something like a property that returns a list of dicts to list all known commands for a device type? That would be a duct tape solution for folks to be able to call the raw commands and a place for contributors to start.

bstrdsmkr · 2023-11-09T15:52:19Z

kasa/modules/time.py

@@ -13,12 +13,16 @@ def query(self):
        q = self.query_for_command("get_time")

        merge(q, self.query_for_command("get_timezone"))
+        merge(q, self.query_for_command("get_time_zone"))


@rytilahti the time module for my camera needs get_time_zone vs get_timezone for all other devices. This merge seems to work, but I'm concerned whether:

This works with all other devices (I only have the camera and a couple of lights)

Is this "The Right Way" to do this?

Maybe it's better to create a separate class that inherits from the Time, that is only used for the camera class? This way we would not send unnecessary requests to devices that do not support this.

edit: Or maybe just a keyword argument to __init__ that takes the name of the method, something like this:

def __init__(self, device: "SmartDevice", module: str, *, query_command="get_timezone"): self._query_command = query_command super().__init__(device, module)

and initializing it with get_time_zone for the camera.

bstrdsmkr · 2023-11-09T16:02:18Z

kasa/tests/fixtures/EC70(US)_2.0_2.3.14.json

@rytilahti This was produced by support I added for cameras to the dump_dev_info script but backed it out to a separate, future PR after review discussion. It's not clear to me how much info these fixtures should contain. Should I manually add example responses for the PTZ module commands?

If you wish to add, that could be helpful for the future. The whole idea behind the fixtures is to have some test responses for commands to hopefully avoid breaking and enabling some development by users (like me) who have just a few devices to test the library against.

rytilahti · 2023-11-18T15:40:48Z

I'd like to implement them eventually but don't want that to hold up this PR and likely won't have time for a bit. What are your thoughts on something like a property that returns a list of dicts to list all known commands for a device type? That would be a duct tape solution for folks to be able to call the raw commands and a place for contributors to start.

It's indeed a good idea to take this in small steps. Instead adding some unused code, how about creating an issue to the issue tracker?

rytilahti · 2023-11-18T15:46:43Z

kasa/smartcamera.py

+        credentials: Credentials,
+        *,


Suggested change

credentials: Credentials,

*,

*,

credentials: Credentials,

For consistency, all other classes expect it as kwarg-only.

rytilahti · 2023-11-18T15:56:36Z

kasa/smartcamera.py

+
+    Examples:
+        >>> import asyncio
+        >>> camera = KasaCam("127.0.0.1")


Old name used here :-) Please add test_camera_examples to kasa/tests/test_readme_examples.py which will catch similar issues in the future.

Can you clarify or suggest the fix here?

The issue is that the name of the class is SmartCamera but the example uses KasaCam.

Hopefullly I'm not to ignorant here, but is it using "KasaCam" because of the TYPE_TO_CLASS in the kasa/cli.py ?

python-kasa/kasa/cli.py

Line 51 in e2d8f52

"kasacam": SmartCamera,

Suggested change

>>> camera = KasaCam("127.0.0.1")

>>> camera = SmartCamera("127.0.0.1")

Is that what you are suggesting?

WingsLikeEagles · 2024-01-08T02:41:17Z

kasa/smartcamera.py

+        self,
+        target: str,
+        cmd: str,
+        arg: Optional[Dict] = None,


If the Kasa Cameras requires {} in place of "None", why not just put that as the default? I'm not a super Python expert, so open to being wrong here if I misunderstand.

Suggested change

arg: Optional[Dict] = None,

arg: Optional[Dict] = {},

Generally speaking it is a good idea to avoid passing mutable objects as parameters, as they are initialized at the time of declaration. I.e., if the method body would modify the arg somehow, all future calls would default to having that modified dictionary as input.

In this case it does not make any difference, but given this function overloads the base class one, it should keep using the same signature.

WingsLikeEagles · 2024-01-08T02:55:18Z

kasa/tests/conftest.py

@@ -156,6 +161,9 @@ def device_for_file(model):
        if d in model:
            return SmartDimmer

+    for d in CAMERAS:
+        if d in model:
+            return SmartCamera


Suggested change

return SmartCamera

return SmartCamera

Adding blank line back in for consistency.

WingsLikeEagles · 2024-01-08T03:02:52Z

kasa/tests/test_discovery.py

@@ -68,7 +75,9 @@ def mock_discover(self):
    mocker.patch.object(_DiscoverProtocol, "do_discover", mock_discover)
    mocker.patch("kasa.TPLinkSmartHomeProtocol.query", return_value=discovery_data)

-    x = await Discover.discover_single(host, port=custom_port)
+    x = await Discover.discover_single(
+        host, port=custom_port, credentials=Credentials("user", "pass")


Suggested change

host, port=custom_port, credentials=Credentials("user", "pass")

host,

port=custom_port,

credentials=Credentials("user", "pass")

I'm not sure if this is applicable for a test, but the default username/password for the EC70 appears to be admin/admin. But the password is base64 encoded. Which I believe works out to YWRtaW4=.

This can be tested with

curl -vv -k -u admin:YWRtaW4= "https://192.168.0.10:19443/https/stream/mixed?video=h264&audio=g711&resolution=hd"

or

curl -vv -k -u admin:$(echo -n "admin" | base64) "https://192.168.0.10:19443/https/stream/mixed?video=h264&audio=g711&resolution=hd"

WingsLikeEagles · 2024-01-08T03:03:18Z

kasa/tests/test_discovery.py

@@ -80,7 +89,9 @@ async def test_connect_single(discovery_data: dict, mocker, custom_port):
    host = "127.0.0.1"
    mocker.patch("kasa.TPLinkSmartHomeProtocol.query", return_value=discovery_data)

-    dev = await Discover.connect_single(host, port=custom_port)
+    dev = await Discover.connect_single(
+        host, port=custom_port, credentials=Credentials("user", "pass")


Suggested change

host, port=custom_port, credentials=Credentials("user", "pass")

host,

port=custom_port,

credentials=Credentials("user", "pass")

rytilahti

Current git master has separated transport from communication protocols, so this PR requires rebasing.

rytilahti · 2024-01-09T23:54:46Z

kasa/smartcamera.py

+
+    Examples:
+        >>> import asyncio
+        >>> camera = KasaCam("127.0.0.1")


The issue is that the name of the class is SmartCamera but the example uses KasaCam.

rytilahti · 2024-01-09T23:56:34Z

kasa/smartcamera.py

+        self,
+        target: str,
+        cmd: str,
+        arg: Optional[Dict] = None,


Generally speaking it is a good idea to avoid passing mutable objects as parameters, as they are initialized at the time of declaration. I.e., if the method body would modify the arg somehow, all future calls would default to having that modified dictionary as input.

In this case it does not make any difference, but given this function overloads the base class one, it should keep using the same signature.

sdb9696 · 2024-01-10T10:30:54Z

Current git master has separated transport from communication protocols, so this PR requires rebasing.

To help here, if I understand the SmartCameraProtocol correctly I think what you will need to do is implement a transport called XorHttpTransport which will implement send (the code you currently have in _connect and _execute_query. I think you should then be able to re-use the IotProtocol with this new transport and all the retry logic and httpx error handling will be done for you.

rytilahti · 2024-01-11T18:59:55Z

It is also necessary to convert this to use aiohttp instead of httpx for performance reasons, see #635.

WingsLikeEagles · 2024-01-13T05:50:27Z

kasa/cli.py

@@ -47,6 +48,7 @@ def wrapper(message=None, *args, **kwargs):
    "bulb": SmartBulb,
    "dimmer": SmartDimmer,
    "strip": SmartStrip,
+    "kasacam": SmartCamera,


Suggested change

"kasacam": SmartCamera,

"camera": SmartCamera,

WingsLikeEagles · 2024-01-13T06:02:27Z

I have an EC70, and I'd really like to get it working with this. @bstrdsmkr hoping you have some time to wrap this up. Excited to see it included.

WingsLikeEagles · 2024-01-13T07:03:59Z

So, not sure how much this helps, but the default user name and password for the EC70 is admin:admin. But the password must be base64 encoded when sent.

From this Reddit: https://www.reddit.com/r/homeautomation/comments/sej7vi/comment/iee9t0s/
They were able to get a stream using port 19443. They used their TP Link cloud user and password.

curl -vv -k -u tp_link_user@email.com:$(echo -n "YOUR_TP_LINK_PASSWORD_HERE" | base64) "https://xxx.xxx.xxx.xxx:19443/https/stream/mixed?video=h264&audio=g711&resolution=hd" --ignore-content-length --output - | cvlc stream:///dev/stdin --sout '#rtp{access=udp,sdp=rtsp://:8554/stream}' :demux=h264

I have verified authentication with

curl -vv -k -u admin:$(echo -n "admin" | base64) "https://xxx.xxx.xxx.xxx:19443/https/stream/mixed?video=h264&audio=g711&resolution=hd"

Actually, base64('admin') is just YWRtaW4=, and the default IP address when you first turn it on is 192.168.0.10. So what I used was:

curl -vv -k -u admin:YWRtaW4= "https://192.168.0.10:19443/https/stream/mixed?video=h264&audio=g711&resolution=hd"

This returns a self signed SSL certificate.

Hope this may be of some help for the discovery portion.

WingsLikeEagles · 2024-01-25T02:32:12Z

@bstrdsmkr just pinging to see if you are still interested in this. I'd like to see this implemented, but it's over my head. Plus, I'm probably going to be forced off GitHub due to their MFA requirements tomorrow.
https://github.com/WingsLikeEagles/No2FA

sdb9696 · 2024-01-30T18:11:13Z

Hi @bstrdsmkr. It's been a while since you commented on this PR and a lot of core library changes have since gone in to support a broader range of tplink devices. That may have made you think it'll be too much trouble to get this PR working but I'd be happy to help you go through it if you're still interested.

bstrdsmkr force-pushed the kasacam_support branch 3 times, most recently from f9179ab to b2c78a1 Compare October 31, 2023 16:04

rytilahti added the enhancement New feature or request label Oct 31, 2023

rytilahti reviewed Oct 31, 2023

View reviewed changes

bstrdsmkr force-pushed the kasacam_support branch 2 times, most recently from 2ea2141 to 3a1db0c Compare November 6, 2023 19:51

bstrdsmkr mentioned this pull request Nov 6, 2023

contributing KasaCam support #530

Open

rytilahti reviewed Nov 7, 2023

View reviewed changes

bstrdsmkr force-pushed the kasacam_support branch 2 times, most recently from 7f83115 to 26ce51a Compare November 7, 2023 19:52

rytilahti mentioned this pull request Nov 8, 2023

Add klap protocol #509

Merged

bstrdsmkr force-pushed the kasacam_support branch 2 times, most recently from 63f7206 to ba63501 Compare November 9, 2023 01:22

Initial WIP review commit

e2d8f52

bstrdsmkr force-pushed the kasacam_support branch from ba63501 to e2d8f52 Compare November 9, 2023 14:24

bstrdsmkr commented Nov 9, 2023

View reviewed changes

rytilahti reviewed Nov 18, 2023

View reviewed changes

rytilahti mentioned this pull request Dec 2, 2023

[Feature Request] KD110 support #467

Open

WingsLikeEagles reviewed Jan 8, 2024

View reviewed changes

rytilahti reviewed Jan 9, 2024

View reviewed changes

WingsLikeEagles reviewed Jan 13, 2024

View reviewed changes

	>>> camera = KasaCam("127.0.0.1")
	>>> camera = SmartCamera("127.0.0.1")

[WIP] Kasa Cam support #537

Are you sure you want to change the base?

[WIP] Kasa Cam support #537

Conversation

bstrdsmkr commented Oct 30, 2023 • edited by rytilahti

codecov bot commented Oct 31, 2023 • edited

Codecov Report

rytilahti left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rytilahti Nov 18, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bstrdsmkr commented Nov 9, 2023

Choose a reason for hiding this comment

rytilahti Nov 18, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rytilahti commented Nov 18, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rytilahti left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sdb9696 commented Jan 10, 2024

rytilahti commented Jan 11, 2024

Choose a reason for hiding this comment

WingsLikeEagles commented Jan 13, 2024

WingsLikeEagles commented Jan 13, 2024 • edited

WingsLikeEagles commented Jan 25, 2024

sdb9696 commented Jan 30, 2024

bstrdsmkr commented Oct 30, 2023 •

edited by rytilahti

codecov bot commented Oct 31, 2023 •

edited

rytilahti Nov 18, 2023 •

edited

rytilahti Nov 18, 2023 •

edited

WingsLikeEagles commented Jan 13, 2024 •

edited