Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

📢 Thoughts on this report? Let us know!.

I'm not sure what's wrong with this, but the unicast discoveries are not being replied by devices. kasa --target 192.168.1.123 discover does not yield any responses where targeting the broadcast address does.

Likewise, I'm not seeing any replies (nor outgoing datagrams, fwiw) when using a script like this:

import asyncio
from kasa import DiscoveryProtocol
from ipaddress import ip_network
from typing import cast


async def on_discovered_callback(dev):
    """handle discovered devices."""
    print(dev)


async def discover_multi(*hosts):
    loop = asyncio.get_event_loop()
    transport, protocol = await loop.create_datagram_endpoint(
        lambda: DiscoveryProtocol(on_discovered=on_discovered_callback),
        local_addr=("0.0.0.0", 0),
    )
    protocol = cast(DiscoveryProtocol, protocol)
    for host in hosts:
        protocol.do_discover(str(host))

    transport.close()
    await asyncio.sleep(5)


asyncio.run(
    discover_multi(
        *ip_network("192.168.xx.0/24").hosts()
    )
)

Looking at the packet trace, it looks like the datagrams are not even been sent out but rather blocked by the kernel?!

Let give this a try. I don't see why it wouldn't work. Maybe an environment thing? I'll have some time this week, I'll get back to you.

Tcpdump shows that the packets are going out alright. But not to all hosts, only a few random ones. Very strange