Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the docker configuration detection (localhost vs 0.0.0.0 vs etc). #23

Open
karolh2000 opened this issue Jan 25, 2023 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@karolh2000
Copy link
Member

We need to improve the algorithm that detects if Pyrsia is already added/configured in the docker config. Right now the logic considers the localhost alternatives as independent but all of them should be equal so if any of them is detected in the docker configuration the command shouldn't suggest to update the configuration. The following hostnames should be consider "equal":

  • localhost
  • 0.0.0.0
  • 127.0.0.1
  • 0:0:0:0:0:0:0:1
  • ::1
  • the actual machine hostname
@karolh2000 karolh2000 added the bug Something isn't working label Jan 25, 2023
@karolh2000 karolh2000 added this to the 0.1.0 milestone Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Backlog
Development

No branches or pull requests

1 participant