Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conda CI build was never actually relying on conda #1515

Open
gonuke opened this issue Dec 24, 2023 · 1 comment · May be fixed by #1527
Open

conda CI build was never actually relying on conda #1515

gonuke opened this issue Dec 24, 2023 · 1 comment · May be fixed by #1527
Assignees
@bquan0

Comments

@gonuke
Copy link
Contributor

gonuke commented Dec 24, 2023

Describe the Bug

conda builds seem to have always used apt by accident because of extra spaces in the build args

To Reproduce

reviewing the CI build logs carefully shows that the base_python stage was passing through the apt_deps stage.

Expected Behavior

The base_python stage should invoke the conda_deps stage.

This was discovered when a manual attempt to build with the conda path failed.
@gonuke
Copy link
Contributor Author

gonuke commented Dec 24, 2023

This also means that our build with conda is far from working properly!!

@bquan0 bquan0 mentioned this issue Dec 25, 2023
Closed
@bquan0 bquan0 linked a pull request Mar 12, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bquan0 bquan0

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@gonuke @bquan0