Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test install scripts with every merge #1491

Open
gonuke opened this issue Jul 22, 2023 · 0 comments
Open

Test install scripts with every merge #1491

gonuke opened this issue Jul 22, 2023 · 0 comments
Assignees
Labels

Comments

@gonuke
Copy link
Contributor

gonuke commented Jul 22, 2023

With #1477 we created a workflow to test a standard installation script within this repo.

Currently, he conditions under which that script runs are too limiting:

  push:
    paths:
      - 'scripts/ubuntu.sh'
      - '.github/workflows/install_script.yml'

I think this test should run on every push to develop and on every pull_request to develop. By doing it on pull_request it will provide early insight to contributors that the installation is broken, but may also place too much burden on them. We can revisit this after some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants